Page MenuHomePhabricator
Differential D13333

[lib] update threadLabel to handle thick threads
ClosedPublic
Actions

Authored by inka on Sep 13 2024, 5:45 AM.
Tags
None
Referenced Files
F3197252: D13333.diff
Sat, Nov 9, 7:50 AM
Unknown Object (File)
Sun, Oct 20, 2:58 PM
Unknown Object (File)
Sun, Oct 20, 2:58 PM
Unknown Object (File)
Sun, Oct 20, 2:58 PM
Unknown Object (File)
Sun, Oct 20, 2:56 PM
Unknown Object (File)
Tue, Oct 15, 1:49 AM
Unknown Object (File)
Mon, Oct 14, 2:29 PM
Unknown Object (File)
Oct 7 2024, 1:06 AM
View All 36 Files
Subscribers
None

Details

Reviewers
tomek
kamil
ashoat
Commits
rCOMM48db54e22644: [lib] update threadLabel to handle thick threads
Summary

issue: ENG-9173

Test Plan

Tested that when creating a chat:

  • if a chat for the selected list of users exists and is thin, proper label for the thin tye is shown
  • if the chat for the selected list of users doesn't exist - "Local DM" is shown, with a lock icon

Tested that in thread settings:

  • if thread is thick, "Local DM" is shown, with a lock icon
  • if thread is thick sidebar, "Thread" with the align-right icon is shown
  • if thread is thin, proper label and icon are shown

Diff Detail

Repository
rCOMM Comm
Branch
inka/fix_marcin
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Sep 13 2024, 5:45 AM
inka added a parent revision: D13320: [web][native] Update UI to not display GENESIS over thick threads.Sep 13 2024, 5:45 AM
inka edited parent revisions, added: D13275: Update search header in chat creation on native not to show GENESIS for thick threads; removed: D13320: [web][native] Update UI to not display GENESIS over thick threads.
Harbormaster completed remote builds in B31610: Diff 44159.Sep 13 2024, 6:02 AM
inka requested review of this revision.Sep 13 2024, 6:02 AM
tomek accepted this revision.Sep 13 2024, 6:07 AM
tomek added inline comments.
lib/shared/thread-utils.js
1223–1224 ↗(On Diff #44159)

Isn't it already handled by threadTypeIsSidebar(threadType)?

This revision is now accepted and ready to land.Sep 13 2024, 6:07 AM
inka updated this revision to Diff 44173.Sep 13 2024, 6:14 AM

Simplify

tomek accepted this revision.Sep 13 2024, 6:15 AM
Harbormaster completed remote builds in B31613: Diff 44173.Sep 13 2024, 6:31 AM
inka added a child revision: D13335: [lib][web][native] Refactor usingOlmViaTunnelbrokerForDMs.Sep 13 2024, 6:58 AM
Closed by commit rCOMM48db54e22644: [lib] update threadLabel to handle thick threads (authored by inka). · Explain WhySep 13 2024, 8:59 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM48db54e22644: [lib] update threadLabel to handle thick threads.

Revision Contents
Changeset List

PathSize
lib/
shared/
2 lines

Diff 44173

View Options

lib/shared/thread-utils.js

Loading...