Page MenuHomePhabricator
Differential D13354

[web] Disable thick thread entries from showing up in the history modal as history entries
ClosedPublic
Actions

Authored by will on Sep 16 2024, 1:20 PM.
Tags
None
Referenced Files
F3539410: D13354.id44257.diff
Thu, Dec 26, 1:11 AM
F3539275: D13354.id44235.diff
Thu, Dec 26, 12:23 AM
F3538920: D13354.id44243.diff
Thu, Dec 26, 12:01 AM
Unknown Object (File)
Wed, Dec 25, 11:54 AM
Unknown Object (File)
Sun, Dec 22, 11:36 PM
Unknown Object (File)
Sun, Dec 22, 11:36 PM
Unknown Object (File)
Sun, Dec 22, 11:36 PM
Unknown Object (File)
Sun, Dec 22, 11:35 PM
View All 59 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
marcin
Commits
rCOMM6348d732c201: [web] Disable thick thread entries from showing up in the history modal as…
Summary

This disables thick thread entries from showing up in the history modal

Depends on D13350

Test Plan

Tested on local webapp. Keyserver history entries still showed up fine but thick thread entries did not

Diff Detail

Repository
rCOMM Comm
Branch
land_thick_thread_entries
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Sep 16 2024, 1:20 PM
ashoat published this revision for review.Sep 16 2024, 1:23 PM
ashoat added inline comments.
web/modals/history/history-modal.react.js
116–117

Shorthand

ashoat accepted this revision.Sep 16 2024, 1:23 PM

Before landing, can you create a follow-up task to create a flag that can gate both this and D13349?

This revision is now accepted and ready to land.Sep 16 2024, 1:23 PM
Harbormaster completed remote builds in B31647: Diff 44235.Sep 16 2024, 1:37 PM
will updated this revision to Diff 44243.Sep 16 2024, 2:08 PM

final rebase

Harbormaster completed remote builds in B31655: Diff 44243.Sep 16 2024, 2:25 PM
Closed by commit rCOMM6348d732c201: [web] Disable thick thread entries from showing up in the history modal as… (authored by will). · Explain WhySep 16 2024, 2:27 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM6348d732c201: [web] Disable thick thread entries from showing up in the history modal as….
ashoat added a comment.Sep 16 2024, 2:36 PM

@will created a follow-up task, but didn't document it here. Here it is: https://linear.app/comm/issue/ENG-9302/create-a-flag-for-enabling-history-on-thick-threaded-entries

Revision Contents
Changeset List

PathSize
web/
modals/
history/
10 lines

Diff 44235

View Options

web/modals/history/history-modal.react.js

Loading...