Page MenuHomePhabricator
Differential D13347

[lib] check timestamps before processing edit entry operation
ClosedPublic
Actions

Authored by will on Sep 16 2024, 1:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 10, 11:10 AM
Unknown Object (File)
Wed, Mar 5, 8:36 AM
Unknown Object (File)
Wed, Mar 5, 12:12 AM
Unknown Object (File)
Fri, Feb 28, 5:25 AM
Unknown Object (File)
Fri, Feb 28, 5:25 AM
Unknown Object (File)
Fri, Feb 28, 5:25 AM
Unknown Object (File)
Fri, Feb 28, 5:25 AM
Unknown Object (File)
Fri, Feb 28, 5:02 AM
View All 81 Files
Subscribers
None

Details

Reviewers
tomek
marcin
ashoat
Commits
rCOMM1a9f981e4063: [lib] check timestamps before processing edit entry operation
Summary

This checks the timestamp to ensure that an edit operation produces a no-op update if produced with a timestamp before latest updated time

Follows logic from https://phab.comm.dev/D13215

Depends on D13346

Test Plan

Not sure how to test this yet. Might manually run these with different timestamps? Unsure how I might be able to introduce a delay.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Sep 16 2024, 1:31 AM
will added a child revision: D13348: [lib] check timestamps before processing delete entry operation.
Harbormaster completed remote builds in B31629: Diff 44201.Sep 16 2024, 2:05 AM
will requested review of this revision.Sep 16 2024, 2:05 AM
will mentioned this in D13341: [lib] DMOperationSpec for edit entry operation.Sep 16 2024, 5:40 AM
tomek accepted this revision.Sep 16 2024, 5:46 AM
tomek added inline comments.
lib/shared/dm-ops/edit-entry-spec.js
46 ↗(On Diff #44201)

It would be easier if we kept this property name consistent between all the operations.

66 ↗(On Diff #44201)

Can we early exit when this condition isn't met? We should return only rawMessageInfos with empty updateInfos in such a case.

This revision is now accepted and ready to land.Sep 16 2024, 5:46 AM
will updated this revision to Diff 44242.Sep 16 2024, 2:08 PM

remove unnecesssary Thick thread type import

Harbormaster completed remote builds in B31654: Diff 44242.Sep 16 2024, 2:25 PM
Closed by commit rCOMM1a9f981e4063: [lib] check timestamps before processing edit entry operation (authored by will). · Explain WhySep 16 2024, 2:27 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM1a9f981e4063: [lib] check timestamps before processing edit entry operation.

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
24 lines

Diff 44242

View Options

lib/shared/dm-ops/edit-entry-spec.js

// @flow // @flow
import _mapValues from 'lodash/fp/mapValues.js'; import _mapValues from 'lodash/fp/mapValues.js';
import type { DMOperationStoreOperation } from '../ops/dm-operations-store-ops.js';
import { import {
clearQueuedEntryDMOpsActionType, clearQueuedEntryDMOpsActionType,
clearQueuedMembershipDMOpsActionType, clearQueuedMembershipDMOpsActionType,
clearQueuedMessageDMOpsActionType, clearQueuedMessageDMOpsActionType,
clearQueuedThreadDMOpsActionType, clearQueuedThreadDMOpsActionType,
type OperationsQueue, type OperationsQueue,
pruneDMOpsQueueActionType, pruneDMOpsQueueActionType,
type QueuedDMOperations, type QueuedDMOperations,
queueDMOpsActionType, queueDMOpsActionType,
} from '../types/dm-ops.js'; } from '../types/dm-ops.js';
import type { BaseAction } from '../types/redux-types.js'; import type { BaseAction } from '../types/redux-types.js';
function reduceDMOperationsQueue( function reduceDMOperationsQueue(
store: QueuedDMOperations, store: QueuedDMOperations,
action: BaseAction, action: BaseAction,
): QueuedDMOperations { ): {
+store: QueuedDMOperations,
+operations: $ReadOnlyArray<DMOperationStoreOperation>,
} {
if (action.type === queueDMOpsActionType) { if (action.type === queueDMOpsActionType) {
const { condition, operation, timestamp } = action.payload; const { condition, operation, timestamp } = action.payload;
if (condition.type === 'thread') { if (condition.type === 'thread') {
return { return {
store: {
...store, ...store,
threadQueue: { threadQueue: {
...store.threadQueue, ...store.threadQueue,
[condition.threadID]: [ [condition.threadID]: [
...(store.threadQueue[condition.threadID] ?? []), ...(store.threadQueue[condition.threadID] ?? []),
{ operation, timestamp }, { operation, timestamp },
], ],
}, },
},
operations: [],
}; };
} }
if (condition.type === 'entry') { if (condition.type === 'entry') {
return { return {
store: {
...store, ...store,
entryQueue: { entryQueue: {
...store.entryQueue, ...store.entryQueue,
[condition.entryID]: [ [condition.entryID]: [
...(store.entryQueue[condition.entryID] ?? []), ...(store.entryQueue[condition.entryID] ?? []),
{ operation, timestamp }, { operation, timestamp },
], ],
}, },
},
operations: [],
}; };
} }
if (condition.type === 'message') { if (condition.type === 'message') {
return { return {
store: {
...store, ...store,
messageQueue: { messageQueue: {
...store.messageQueue, ...store.messageQueue,
[condition.messageID]: [ [condition.messageID]: [
...(store.messageQueue[condition.messageID] ?? []), ...(store.messageQueue[condition.messageID] ?? []),
{ operation, timestamp }, { operation, timestamp },
], ],
}, },
},
operations: [],
}; };
} }
return { return {
store: {
...store, ...store,
membershipQueue: { membershipQueue: {
...store.membershipQueue, ...store.membershipQueue,
[condition.threadID]: { [condition.threadID]: {
...(store.membershipQueue[condition.threadID] ?? {}), ...(store.membershipQueue[condition.threadID] ?? {}),
[condition.userID]: [ [condition.userID]: [
...(store.membershipQueue[condition.threadID]?.[condition.userID] ?? ...(store.membershipQueue[condition.threadID]?.[
[]), condition.userID
] ?? []),
{ operation, timestamp }, { operation, timestamp },
], ],
}, },
}, },
},
operations: [],
}; };
} else if (action.type === pruneDMOpsQueueActionType) { } else if (action.type === pruneDMOpsQueueActionType) {
const filterOperations = (queue: OperationsQueue) => const filterOperations = (queue: OperationsQueue) =>
queue.filter(op => op.timestamp >= action.payload.pruneMaxTimestamp); queue.filter(op => op.timestamp >= action.payload.pruneMaxTimestamp);
return { return {
store: {
...store, ...store,
threadQueue: _mapValues(operations => filterOperations(operations))( threadQueue: _mapValues(operations => filterOperations(operations))(
store.threadQueue, store.threadQueue,
), ),
messageQueue: _mapValues(operations => filterOperations(operations))( messageQueue: _mapValues(operations => filterOperations(operations))(
store.messageQueue, store.messageQueue,
), ),
entryQueue: _mapValues(operations => filterOperations(operations))( entryQueue: _mapValues(operations => filterOperations(operations))(
store.entryQueue, store.entryQueue,
), ),
membershipQueue: _mapValues(threadMembershipQueue => membershipQueue: _mapValues(threadMembershipQueue =>
_mapValues(operations => filterOperations(operations))( _mapValues(operations => filterOperations(operations))(
threadMembershipQueue, threadMembershipQueue,
), ),
)(store.membershipQueue), )(store.membershipQueue),
},
operations: [],
}; };
} else if (action.type === clearQueuedThreadDMOpsActionType) { } else if (action.type === clearQueuedThreadDMOpsActionType) {
const { [action.payload.threadID]: removed, ...threadQueue } = const { [action.payload.threadID]: removed, ...threadQueue } =
store.threadQueue; store.threadQueue;
return { return {
store: {
...store, ...store,
threadQueue, threadQueue,
},
operations: [],
}; };
} else if (action.type === clearQueuedMessageDMOpsActionType) { } else if (action.type === clearQueuedMessageDMOpsActionType) {
const { [action.payload.messageID]: removed, ...messageQueue } = const { [action.payload.messageID]: removed, ...messageQueue } =
store.messageQueue; store.messageQueue;
return { return {
store: {
...store, ...store,
messageQueue, messageQueue,
},
operations: [],
}; };
} else if (action.type === clearQueuedEntryDMOpsActionType) { } else if (action.type === clearQueuedEntryDMOpsActionType) {
const { [action.payload.entryID]: removed, ...entryQueue } = const { [action.payload.entryID]: removed, ...entryQueue } =
store.entryQueue; store.entryQueue;
return { return {
store: {
...store, ...store,
entryQueue, entryQueue,
},
operations: [],
}; };
} else if (action.type === clearQueuedMembershipDMOpsActionType) { } else if (action.type === clearQueuedMembershipDMOpsActionType) {
const threadQueue = store.membershipQueue[action.payload.threadID]; const threadQueue = store.membershipQueue[action.payload.threadID];
if (!threadQueue) { if (!threadQueue) {
return store; return { store, operations: [] };
} }
const { [action.payload.userID]: removed, ...queue } = threadQueue; const { [action.payload.userID]: removed, ...queue } = threadQueue;
if (Object.keys(queue).length === 0) { if (Object.keys(queue).length === 0) {
const { [action.payload.threadID]: removedThread, ...membershipQueue } = const { [action.payload.threadID]: removedThread, ...membershipQueue } =
store.membershipQueue; store.membershipQueue;
return { return {
store: {
...store, ...store,
membershipQueue, membershipQueue,
},
operations: [],
}; };
} }
return { return {
store: {
...store, ...store,
membershipQueue: { membershipQueue: {
...store.membershipQueue, ...store.membershipQueue,
[action.payload.userID]: queue, [action.payload.userID]: queue,
}, },
},
operations: [],
}; };
} }
return store; return { store, operations: [] };
} }
export { reduceDMOperationsQueue }; export { reduceDMOperationsQueue };