Page MenuHomePhabricator
Differential D13409

[lib] Add functions to perform Blob Service holder actions
AcceptedPublic
Actions

Authored by bartek on Fri, Sep 20, 6:24 AM.
Tags
None
Referenced Files
F2786152: D13409.diff
Fri, Sep 20, 10:29 PM
F2785769: D13409.diff
Fri, Sep 20, 8:21 PM
F2783026: D13409.id.diff
Fri, Sep 20, 4:45 PM
F2780426: D13409.diff
Fri, Sep 20, 2:02 PM
F2779277: D13409.id44372.diff
Fri, Sep 20, 10:08 AM
F2779257: D13409.id.diff
Fri, Sep 20, 10:07 AM
F2779231: D13409.diff
Fri, Sep 20, 10:06 AM
Subscribers
ashoat

Details

Reviewers
kamil
tomek
Summary

Added function that perform Blob Service calls for adding/removing holders. Used input/output format compatible with action introduced in D13408
This can be simplified when batch endpoints are implemented for holders on Blob service.

Depends on D13408

Test Plan

Tested together with the next diff.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Fri, Sep 20, 6:24 AM
bartek held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptFri, Sep 20, 6:24 AM
bartek added a child revision: D13411: [lib] Process blob holders in DM ops.Fri, Sep 20, 6:30 AM
Harbormaster completed remote builds in B31738: Diff 44372.Fri, Sep 20, 6:40 AM
bartek published this revision for review.Fri, Sep 20, 6:43 AM
kamil accepted this revision.Fri, Sep 20, 8:40 AM
kamil added inline comments.
lib/actions/holder-actions.js
44–47

This could be different than assigning holder

77–82

nit: I would create two arrays and use a loop to iterate only once

This revision is now accepted and ready to land.Fri, Sep 20, 8:40 AM

Revision Contents
Changeset List

PathSize
lib/
actions/
89 lines

Diff 44372

View Options

lib/actions/holder-actions.js

Loading...