[lib] Add functions to perform Blob Service holder actions
ClosedPublic
Actions

Authored by bartek on Sep 20 2024, 1:24 PM.

Details

Reviewers

kamil
tomek

Commits

rCOMMeec870466c07: [lib] Add functions to perform Blob Service holder actions

Summary

Added function that perform Blob Service calls for adding/removing holders. Used input/output format compatible with action introduced in D13408
This can be simplified when batch endpoints are implemented for holders on Blob service.

Depends on D13408

Test Plan

Tested together with the next diff.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Sep 20 2024, 1:24 PM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptSep 20 2024, 1:24 PM

bartek added a child revision: D13411: [lib] Process blob holders in DM ops.Sep 20 2024, 1:30 PM

Harbormaster completed remote builds in B31738: Diff 44372.Sep 20 2024, 1:40 PM

bartek published this revision for review.Sep 20 2024, 1:43 PM

kamil accepted this revision.Sep 20 2024, 3:40 PM

kamil added inline comments.

lib/actions/holder-actions.js
44–47	This could be different than assigning holder
77–82	nit: I would create two arrays and use a loop to iterate only once

This revision is now accepted and ready to land.Sep 20 2024, 3:40 PM

Address feedback

bartek added inline comments.Sep 23 2024, 12:17 PM

lib/actions/holder-actions.js
9 ↗	(On Diff #44415)	This newline is fixed locally in rebase after updating D13408

Harbormaster completed remote builds in B31768: Diff 44415.Sep 23 2024, 12:19 PM

Closed by commit rCOMMeec870466c07: [lib] Add functions to perform Blob Service holder actions. · Explain WhySep 23 2024, 2:24 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMeec870466c07: [lib] Add functions to perform Blob Service holder actions.

Revision Contents
Changeset List

Path

Size

lib/

actions/

holder-actions.js

89 lines

Diff 44372

View Options

lib/actions/holder-actions.js

[lib] Add functions to perform Blob Service holder actionsClosedPublicActions