Page MenuHomePhabricator

[lib] Add functions to perform Blob Service holder actions
ClosedPublic

Authored by bartek on Sep 20 2024, 6:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 28, 5:05 AM
Unknown Object (File)
Sat, Dec 28, 5:05 AM
Unknown Object (File)
Sat, Dec 28, 5:05 AM
Unknown Object (File)
Sat, Dec 28, 5:04 AM
Unknown Object (File)
Sat, Dec 28, 5:04 AM
Unknown Object (File)
Nov 20 2024, 10:35 AM
Unknown Object (File)
Nov 20 2024, 10:35 AM
Unknown Object (File)
Nov 20 2024, 10:35 AM
Subscribers

Details

Summary

Added function that perform Blob Service calls for adding/removing holders. Used input/output format compatible with action introduced in D13408
This can be simplified when batch endpoints are implemented for holders on Blob service.

Depends on D13408

Test Plan

Tested together with the next diff.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Sep 20 2024, 6:43 AM
kamil added inline comments.
lib/actions/holder-actions.js
44–47 ↗(On Diff #44372)

This could be different than assigning holder

77–82 ↗(On Diff #44372)

nit: I would create two arrays and use a loop to iterate only once

This revision is now accepted and ready to land.Sep 20 2024, 8:40 AM
lib/actions/holder-actions.js
9

This newline is fixed locally in rebase after updating D13408