Created a hook that removes all holders from holder store, using the "process holders" action.
Called the hook in useLogOut() which is called for all logout actions (identity v1, legacy, primary/secondary).
Depends on D13411
Details
Details
- Reviewers
kamil tomek - Commits
- rCOMM7ec573d10cd5: [lib] Clear all holders on logout
Established a few holders, then logged out. Verified that Blob Service was called
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/actions/holder-actions.js | ||
|---|---|---|
| 143 ↗ | (On Diff #44390) | Leftover |
Comment Actions
Accepting for now, some more context about why this isn't ideal in ENG-9351.
| lib/actions/user-actions.js | ||
|---|---|---|
| 210 ↗ | (On Diff #44390) | removeAllHolders might throw - I think we should avoid this to allow callKeyserverLogOut to finish, we should do something similar to identityPromise. On the other hand, maybe it is worth starting this promise before Identity logout, without awaiting to make it more realistic to resolve before removing CSAT but without blocking the logout call. |
Comment Actions
I agree with @kamil that we should avoid log out throwing... the user should always be able to log out