Page MenuHomePhabricator
Differential D13482

[blob] Use new blob-exists check in single endpoint
ClosedPublic
Actions

Authored by bartek on Sep 26 2024, 12:40 AM.
Tags
None
Referenced Files
F3290791: D13482.id44587.diff
Sat, Nov 16, 3:28 PM
Unknown Object (File)
Sun, Nov 10, 4:18 PM
Unknown Object (File)
Fri, Nov 8, 3:02 AM
Unknown Object (File)
Fri, Nov 8, 3:02 AM
Unknown Object (File)
Fri, Nov 1, 4:22 PM
Unknown Object (File)
Fri, Nov 1, 6:21 AM
Unknown Object (File)
Fri, Nov 1, 6:20 AM
Unknown Object (File)
Fri, Nov 1, 6:00 AM
View All 32 Files
Subscribers
ashoat
tomek

Details

Reviewers
will
varun
kamil
marcin
Commits
rCOMM8ce683c9558f: [blob] Use new blob-exists check in single endpoint
Summary

Despite D13481, multiple GetItem DDB calls were still happening inside service.assign_holder(). Removed that call there and updated single endpoint to use the new way.

Updated single assign-holder endpoint to use the new batch function.

Depends on D13481

Test Plan
  • Made sure data_exists has still correct value for the POST /blob endpoint
  • Blob integration tests

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
services/
blob/
src/
http/
handlers/
13 lines
5 lines
7 lines

Diff 44634

View Options

services/blob/src/http/handlers/blob.rs

Loading...
View Options

services/blob/src/http/handlers/holders.rs

Loading...
View Options

services/blob/src/service.rs

Loading...