Paths

Table of Contentst

Differential D13551

[lib][native][web] Use threadTypeIsPersonal where possible
ClosedPublic
Actions

Authored by ashoat on Sep 30 2024, 10:11 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Dec 18, 11:53 AM

	Unknown Object (File)
	Wed, Dec 18, 11:53 AM

	Unknown Object (File)
	Wed, Dec 18, 11:53 AM

	Unknown Object (File)
	Wed, Dec 18, 11:52 AM

	Unknown Object (File)
	Wed, Dec 18, 11:52 AM

	Unknown Object (File)
	Nov 24 2024, 11:58 AM

	Unknown Object (File)
	Nov 24 2024, 8:33 AM

	Unknown Object (File)
	Nov 19 2024, 9:17 AM

View All 53 Files

Subscribers

None

Details

Reviewers

tomek
kamil
inka

Commits

rCOMM6a2457d95703: [lib][native][web] Use threadTypeIsPersonal where possible

Summary

This diff is a no-op. I want to reduce the number of places we use GENESIS_PERSONAL in the codebase, so that the only results for git grep GENESIS_PERSONAL are places where we need to specifically consider GENESIS_PERSONAL rather than general places we are considering personal threads.

Depends on D13550

Test Plan

Careful code inspection

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Sep 30 2024, 10:11 PM

ashoat added a child revision: D13552: [lib] Use PERSONAL instead of GENESIS_PERSONAL for default thread noun in getNameForThreadEntity.

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 30 2024, 10:26 PM

Harbormaster failed remote builds in B31967: Diff 44732!

ESLint

Harbormaster completed remote builds in B31971: Diff 44736.Sep 30 2024, 11:47 PM

ashoat requested review of this revision.Sep 30 2024, 11:47 PM

tomek accepted this revision.Oct 1 2024, 8:19 AM

This revision is now accepted and ready to land.Oct 1 2024, 8:19 AM

Closed by commit rCOMM6a2457d95703: [lib][native][web] Use threadTypeIsPersonal where possible (authored by ashoat). · Explain WhyOct 1 2024, 9:07 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM6a2457d95703: [lib][native][web] Use threadTypeIsPersonal where possible.

Revision Contents
Changeset List

Path

Size

lib/

shared/

sidebar-utils.js

12 lines

native/

chat/

message-list.react.js

7 lines

web/

chat/

chat-message-list.react.js

7 lines

Diff 44736

lib/shared/sidebar-utils.js

Loading...

native/chat/message-list.react.js

Loading...

web/chat/chat-message-list.react.js

Loading...