Page MenuHomePhabricator

[native][web] Go to PRIVATE chat when the user selects themselves in chat composer
ClosedPublic

Authored by ashoat on Sep 30 2024, 10:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 4:20 PM
Unknown Object (File)
Fri, Nov 8, 3:01 AM
Unknown Object (File)
Fri, Nov 1, 4:46 PM
Unknown Object (File)
Fri, Nov 1, 5:35 AM
Unknown Object (File)
Thu, Oct 31, 2:02 AM
Unknown Object (File)
Fri, Oct 25, 6:22 PM
Unknown Object (File)
Tue, Oct 22, 5:34 AM
Unknown Object (File)
Tue, Oct 22, 5:32 AM
Subscribers
None

Details

Summary

We'll handle this just like when the user selects a non-friend: we'll just open the chat directly.

We we want to treat this case similarly to when the viewer selects a non-friend: instead of letting them include themselves in the list, we will just open directly to the PRIVATE if the user select themselves at the start (this diff), and not list them as an option if they select somebody else at the start (D13543).

Depends on D13544

Test Plan

On both native and web, confirm that when the viewer selects themselves, it opens up the pending thread directly

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek added inline comments.
native/chat/message-list-container.react.js
391–393 ↗(On Diff #44726)

We can consider simplifying it

This revision is now accepted and ready to land.Oct 1 2024, 8:13 AM