Paths

Table of Contentst

Differential D13538

[lib] Handle private threads differently from personal ones in thread list search
ClosedPublic
Actions

Authored by ashoat on Mon, Sep 30, 9:49 PM.

Tags

None

Referenced Files

	F2860711: D13538.diff
	Tue, Oct 1, 7:28 PM

	F2859877: D13538.id.diff
	Tue, Oct 1, 3:00 PM

	F2859633: D13538.diff
	Tue, Oct 1, 2:25 PM

	F2859605: D13538.id44719.diff
	Tue, Oct 1, 2:08 PM

	F2859595: D13538.diff
	Tue, Oct 1, 2:03 PM

	F2853629: D13538.id44719.diff
	Mon, Sep 30, 10:29 PM

	F2853540: D13538.id.diff
	Mon, Sep 30, 10:27 PM

	F2853383: D13538.diff
	Mon, Sep 30, 10:12 PM

Subscribers

None

Details

Reviewers

tomek
kamil
inka

Commits

rCOMM61156cda411f: [lib] Handle private threads differently from personal ones in thread list…

Summary

The parent diff adds private threads to the results, but they show up as personal threads.

This diff makes them show up correctly.

Depends on D13537

Test Plan

In combination with the rest of the stack, test creating a PRIVATE thread via thread list search on both web and native

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Mon, Sep 30, 9:49 PM

ashoat added a child revision: D13539: [lib] Support creating private thread from user profile.Mon, Sep 30, 9:52 PM

Harbormaster completed remote builds in B31954: Diff 44719.Mon, Sep 30, 10:21 PM

ashoat requested review of this revision.Mon, Sep 30, 10:21 PM

tomek accepted this revision.Tue, Oct 1, 8:42 AM

This revision is now accepted and ready to land.Tue, Oct 1, 8:42 AM

Closed by commit rCOMM61156cda411f: [lib] Handle private threads differently from personal ones in thread list… (authored by ashoat). · Explain WhyTue, Oct 1, 9:07 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM61156cda411f: [lib] Handle private threads differently from personal ones in thread list….

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

23 lines

Diff 44768

lib/shared/thread-utils.js

Loading...