Page MenuHomePhabricator

[lib] Support creating private thread from user profile
ClosedPublic

Authored by ashoat on Sep 30 2024, 9:52 PM.
Tags
None
Referenced Files
F3311487: D13539.id44769.diff
Tue, Nov 19, 9:02 AM
Unknown Object (File)
Sun, Nov 10, 4:20 PM
Unknown Object (File)
Fri, Nov 8, 3:01 AM
Unknown Object (File)
Fri, Nov 8, 3:00 AM
Unknown Object (File)
Fri, Nov 1, 4:46 PM
Unknown Object (File)
Fri, Nov 1, 12:24 PM
Unknown Object (File)
Fri, Nov 1, 5:37 AM
Unknown Object (File)
Thu, Oct 31, 8:25 PM
Subscribers
None

Details

Summary

Before this diff, when no private thread existed, we wouldn't show a chat link in the user's own user profile. We didn't need to consider such a scenario since we always created a GENESIS_PRIVATE thread on account creation.

This diff changes behavior such that if !oldestPrivateThreadInfo (no private chat exists), we no longer return null from useUserProfileThreadInfo, and instead continue on to the createPendingPersonalOrPrivateThread call.

Depends on D13538

Test Plan

In combination with the rest of the stack, test creating a PRIVATE thread via thread list search on both web and native

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable