Page MenuHomePhabricator

[web] Only call userInfoSelectorForPotentialMembers where it's needed
ClosedPublic

Authored by ashoat on Sep 30 2024, 9:54 PM.
Tags
None
Referenced Files
F3311476: D13541.id44722.diff
Tue, Nov 19, 8:56 AM
Unknown Object (File)
Sun, Nov 10, 4:20 PM
Unknown Object (File)
Fri, Nov 8, 3:01 AM
Unknown Object (File)
Fri, Nov 8, 3:01 AM
Unknown Object (File)
Fri, Nov 1, 4:46 PM
Unknown Object (File)
Fri, Nov 1, 5:35 AM
Unknown Object (File)
Oct 19 2024, 3:04 PM
Unknown Object (File)
Oct 13 2024, 8:46 AM
Subscribers
None

Details

Summary

The only callsite of useInfosForPendingThread that needs otherUserInfos is ChatMessageListContainer. It's only needed there to pass to ChatThreadComposer.

To avoid fetching it unnecessarily at the other callsites, I've extracted it to that single callsite. This also benefits code readability by reducing indirection and unnecessary prop drilling.

Depends on D13540

Test Plan

Flow (this is a pure refactor)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable