Paths

Table of Contentst

Differential D13544

[web] Swap order of conditions in ChatThreadComposer onSelectUserFromSearch
ClosedPublic
Actions

Authored by ashoat on Sep 30 2024, 10:01 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Dec 18, 11:53 AM

	Unknown Object (File)
	Wed, Dec 18, 11:53 AM

	Unknown Object (File)
	Wed, Dec 18, 11:52 AM

	Unknown Object (File)
	Wed, Dec 18, 11:52 AM

	Unknown Object (File)
	Nov 24 2024, 12:24 PM

	Unknown Object (File)
	Nov 19 2024, 7:46 AM

	Unknown Object (File)
	Nov 10 2024, 4:20 PM

	Unknown Object (File)
	Nov 8 2024, 3:01 AM

View All 36 Files

Subscribers

None

Details

Reviewers

tomek
kamil
inka

Commits

rCOMM528961244cdc: [web] Swap order of conditions in ChatThreadComposer onSelectUserFromSearch

Summary

This is safe because when sortedMembers in usePotentialMemberItems sets notFriendNotice, it also sets an alert.

Depends on D13543

Test Plan

Careful reading of the code indicates that this is a no-op

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Sep 30 2024, 10:01 PM

ashoat mentioned this in D13545: [native][web] Go to PRIVATE chat when the user selects themselves in chat composer.

ashoat added a child revision: D13545: [native][web] Go to PRIVATE chat when the user selects themselves in chat composer.Sep 30 2024, 10:04 PM

Harbormaster completed remote builds in B31960: Diff 44725.Sep 30 2024, 10:52 PM

ashoat requested review of this revision.Sep 30 2024, 10:52 PM

tomek accepted this revision.Oct 1 2024, 8:07 AM

This revision is now accepted and ready to land.Oct 1 2024, 8:07 AM

Closed by commit rCOMM528961244cdc: [web] Swap order of conditions in ChatThreadComposer onSelectUserFromSearch (authored by ashoat). · Explain WhyOct 1 2024, 9:07 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM528961244cdc: [web] Swap order of conditions in ChatThreadComposer onSelectUserFromSearch.

Revision Contents
Changeset List

Path

Size

web/

chat/

chat-thread-composer.react.js

19 lines

Diff 44774

web/chat/chat-thread-composer.react.js

Loading...