[lib] Use PERSONAL instead of GENESIS_PERSONAL for default thread noun in getNameForThreadEntity
ClosedPublic
Actions

Authored by ashoat on Sep 30 2024, 10:11 PM.

Details

Reviewers

tomek
kamil
inka

Commits

rCOMMd6d57ba2dde9: [lib] Use PERSONAL instead of GENESIS_PERSONAL for default thread noun in…

Summary

This diff is a no-op, as both of these return the same thing when passed to threadNoun. I thought it would be better to use PERSONAL here, to reduce the number of places in the codebase we use GENESIS_PERSONAL.

Depends on D13551

Test Plan

Careful code inspection

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Sep 30 2024, 10:11 PM

ashoat added a child revision: D13553: [web] Use PRIVATE instead of GENESIS_PRIVATE in baseThreadInfo passed to useExistingThreadInfoFinder.

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 30 2024, 10:27 PM

Harbormaster failed remote builds in B31968: Diff 44733!

Rebase

Harbormaster completed remote builds in B31972: Diff 44737.Sep 30 2024, 11:56 PM

ashoat requested review of this revision.Sep 30 2024, 11:56 PM

tomek accepted this revision.Oct 1 2024, 8:23 AM

This revision is now accepted and ready to land.Oct 1 2024, 8:23 AM

Closed by commit rCOMMd6d57ba2dde9: [lib] Use PERSONAL instead of GENESIS_PERSONAL for default thread noun in… (authored by ashoat). · Explain WhyOct 1 2024, 9:07 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMd6d57ba2dde9: [lib] Use PERSONAL instead of GENESIS_PERSONAL for default thread noun in….

Revision Contents
Changeset List

Path

Size

lib/

utils/

entity-text.js

2 lines

Diff 44782

View Options

[lib] Use PERSONAL instead of GENESIS_PERSONAL for default thread noun in getNameForThreadEntityClosedPublicActions