Can you send me the invite link, and when I join make me an admin?

Shouldn't we be using validFarcasterUsers here?

Hmm, it's kind of weird that we have the lead user create the community even if they took no action

We've gotten feedback recently about misleading robotext that indicates a user took an action when they didn't (ENG-9511)

Ideally we could create the community as the tagger, but make the lead the admin. To make this work, we'd need some changes to createThread, so that it when it calls changeRole for these users, it passes a different role ID

I'd suggest replacing the definition as such:

// old
async function createThread(
  viewer: Viewer,
  request: ServerNewThinThreadRequest,
  options?: CreateThreadOptions,
): Promise<NewThreadResponse> {
  ...
}
// new
type CreateThreadRequest = $ReadOnly<{
  ...ServerNewThinThreadRequest,
  +initialAdminIDs?: ?$ReadOnlyArray<string>,
  +dontMakeViewerAdmin?: ?boolean,
}>;
async function createThread(
  viewer: Viewer,
  request: CreateThreadRequest,
  options?: CreateThreadOptions,
): Promise<NewThreadResponse> {
  ...
}

Shouldn't we always include the tagger in initialMemberIDs, even if we didn't pick them as the admin?

We'll probably also need forceAddMembers, to make sure that members get added even if the admin and the tagger are not friends on Comm

It seems like it will be harder to test this when you're directly using an env var vs getCommConfig, which supports both env vars as well as JSON config files

Does this work?

In my last review, I suggested doing this differently:

To make this work, we'd need some changes to createThread, so that it when it calls changeRole for these users, it passes a different role ID

I'd suggest replacing the definition as such:

// old
async function createThread(
  viewer: Viewer,
  request: ServerNewThinThreadRequest,
  options?: CreateThreadOptions,
): Promise<NewThreadResponse> {
  ...
}
// new
type CreateThreadRequest = $ReadOnly<{
  ...ServerNewThinThreadRequest,
  +initialAdminIDs?: ?$ReadOnlyArray<string>,
  +dontMakeViewerAdmin?: ?boolean,
}>;
async function createThread(
  viewer: Viewer,
  request: CreateThreadRequest,
  options?: CreateThreadOptions,
): Promise<NewThreadResponse> {
  ...
}

I was suggesting this approach because I wanted to avoid a robotext being printed about a user being promoted to admin. This matches the behavior introduced in D13300.

Can you walk me through why you decided to take a different approach here? I'm open to printing the robotext, but we should probably update joinThread too if that's the approach we want to take.

Do we need to wait until this point to start this promise?

We shouldn't need the ?? false here. It looks like you're using a single type in D13781 when you should be used two types

Did this end up happening in a separate diff?