Page MenuHomePhabricator
Differential D13927

[keyserver] Have @babel/preset-react use automatic runtime
AcceptedPublic
Actions

Authored by will on Wed, Nov 13, 11:44 AM.
Tags
None
Referenced Files
F3300779: D13927.id45848.diff
Sun, Nov 17, 9:49 PM
F3300777: D13927.id45817.diff
Sun, Nov 17, 9:48 PM
F3300740: D13927.id45815.diff
Sun, Nov 17, 9:32 PM
F3300042: D13927.id45849.diff
Sun, Nov 17, 4:47 PM
F3300041: D13927.id45848.diff
Sun, Nov 17, 4:47 PM
F3300040: D13927.id45817.diff
Sun, Nov 17, 4:47 PM
F3300039: D13927.id45815.diff
Sun, Nov 17, 4:47 PM
F3300038: D13927.id.diff
Sun, Nov 17, 4:47 PM
View All 16 Files
Subscribers
tomek

Details

Reviewers
ashoat
Summary

This changes the preset-react to use the automatic runtime instead of classic

Further details can be found in the description of https://linear.app/comm/issue/ENG-9914/configure-babelpreset-react-to-use-automatic-runtime-instead-of

Depends on D13926

Test Plan

Will test more thoroughly later in the stack. Including the changes in this diff removes the importSource cannot be set when runtime is classic error when we try to import hono/jsx

Diff Detail

Repository
rCOMM Comm
Branch
frames
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Wed, Nov 13, 11:44 AM
Herald added a subscriber: tomek. · View Herald TranscriptWed, Nov 13, 11:44 AM
will published this revision for review.Wed, Nov 13, 11:45 AM
will updated this revision to Diff 45817.Wed, Nov 13, 11:54 AM

rebase

Harbormaster completed remote builds in B32656: Diff 45815.Wed, Nov 13, 12:45 PM
ashoat accepted this revision.Wed, Nov 13, 12:50 PM
This revision is now accepted and ready to land.Wed, Nov 13, 12:50 PM
Harbormaster completed remote builds in B32658: Diff 45817.Wed, Nov 13, 12:51 PM
will updated this revision to Diff 45848.EditedFri, Nov 15, 10:45 AM

avoid flow errors by setting react.runtime option to automatic

Harbormaster failed remote builds in B32685: Diff 45848!Fri, Nov 15, 10:52 AM
will updated this revision to Diff 45849.Fri, Nov 15, 11:15 AM

move react.automatic line

Harbormaster failed remote builds in B32686: Diff 45849!Fri, Nov 15, 11:19 AM
Harbormaster completed remote builds in B32685: Diff 45848.Fri, Nov 15, 11:24 AM
will added a child revision: D13947: [keyserver] frog hello world example.Fri, Nov 15, 12:07 PM

Revision Contents
Changeset List

PathSize
keyserver/
5 lines

Diff 45815

View Options

keyserver/.babelrc.cjs

Loading...