Page MenuHomePhabricator
Differential D13927

[keyserver] Have @babel/preset-react use automatic runtime
ClosedPublic
Actions

Authored by will on Nov 13 2024, 11:44 AM.
Tags
None
Referenced Files
F3512941: D13927.diff
Sat, Dec 21, 9:11 PM
Unknown Object (File)
Fri, Dec 20, 8:02 PM
Unknown Object (File)
Thu, Dec 19, 10:02 PM
Unknown Object (File)
Thu, Dec 19, 4:13 AM
Unknown Object (File)
Mon, Dec 16, 1:06 AM
Unknown Object (File)
Mon, Dec 16, 1:06 AM
Unknown Object (File)
Mon, Dec 16, 1:06 AM
Unknown Object (File)
Mon, Dec 16, 1:06 AM
View All 49 Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMM556454795e08: [keyserver] Have @babel/preset-react use automatic runtime
Summary

This changes the preset-react to use the automatic runtime instead of classic

Further details can be found in the description of https://linear.app/comm/issue/ENG-9914/configure-babelpreset-react-to-use-automatic-runtime-instead-of

Depends on D13926

Test Plan

Will test more thoroughly later in the stack. Including the changes in this diff removes the importSource cannot be set when runtime is classic error when we try to import hono/jsx

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Nov 13 2024, 11:44 AM
Herald added a subscriber: tomek. · View Herald TranscriptNov 13 2024, 11:44 AM
will published this revision for review.Nov 13 2024, 11:45 AM
will updated this revision to Diff 45817.Nov 13 2024, 11:54 AM

rebase

Harbormaster completed remote builds in B32656: Diff 45815.Nov 13 2024, 12:45 PM
ashoat accepted this revision.Nov 13 2024, 12:50 PM
This revision is now accepted and ready to land.Nov 13 2024, 12:50 PM
Harbormaster completed remote builds in B32658: Diff 45817.Nov 13 2024, 12:51 PM
will updated this revision to Diff 45848.EditedNov 15 2024, 10:45 AM

avoid flow errors by setting react.runtime option to automatic

Harbormaster failed remote builds in B32685: Diff 45848!Nov 15 2024, 10:52 AM
will updated this revision to Diff 45849.Nov 15 2024, 11:15 AM

move react.automatic line

Harbormaster failed remote builds in B32686: Diff 45849!Nov 15 2024, 11:19 AM
Harbormaster completed remote builds in B32685: Diff 45848.Nov 15 2024, 11:24 AM
will added a child revision: D13947: [keyserver] frog hello world example.Nov 15 2024, 12:07 PM
This revision was landed with ongoing or failed builds.Mon, Dec 9, 4:56 PM
Closed by commit rCOMM556454795e08: [keyserver] Have @babel/preset-react use automatic runtime (authored by will). · Explain Why
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM556454795e08: [keyserver] Have @babel/preset-react use automatic runtime.
Harbormaster completed remote builds in B32686: Diff 45849.Mon, Dec 9, 5:00 PM

Revision Contents
Changeset List

PathSize
keyserver/
5 lines
1 line

Diff 45848

View Options

keyserver/.babelrc.cjs

Loading...
View Options

keyserver/.flowconfig

Loading...