This diff implements a hello world Frog application and serves it on port 3001.
Depends on D13927
Details
Details
- Reviewers
ashoat
GET requests to the keyserver at localhost:3001 contain valid HTML document in the response.
Used ngrok to create a publicly accessible url forwarding requests to locahost:3001. Used this url to validate the frame with the warpcast frame validator at https://warpcast.com/~/developers/frames?url=https://81fb-69-201-171-11.ngrok-free.app
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- wyilio/frames
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| keyserver/src/frog/frog.js | ||
|---|---|---|
| 13–22 ↗ | (On Diff #45850) | The JSX here will be replaced later in the stack. This is a placeholder |
| keyserver/.eslintrc.json | ||
|---|---|---|
| 13 ↗ | (On Diff #45850) | We talked about doing this via a // eslint-disable macro... why'd you decide against it? |
| keyserver/.eslintrc.json | ||
|---|---|---|
| 13 ↗ | (On Diff #45850) | Realizing I can do this with the macro specifically for the react/react-in-jsx-scope rule. I mistakenly thought disabling rules for entire files could only be done with eslintrc.json. A quick look through the codebase confirmed we should use the macro. I found several examples of disabling certain blocks of code by surrounding it with: We do seem to disable eslint rules for the entire file in a few places in native (ex. native/index.js) and scripts, but I think the block approach seems appropriate for this diff. |