Paths

Table of Contentst

Differential D13988

[lib][keyserver] Handle invalid CSAT in BlobOperationResult
ClosedPublic
Actions

Authored by bartek on Nov 21 2024, 3:58 AM.

Tags

None

Referenced Files

	F3540898: D13988.id45919.diff
	Thu, Dec 26, 5:51 AM

	F3540897: D13988.id45925.diff
	Thu, Dec 26, 5:51 AM

	F3540800: D13988.id.diff
	Thu, Dec 26, 5:50 AM

	F3540730: D13988.diff
	Thu, Dec 26, 5:44 AM

	Unknown Object (File)
	Tue, Dec 24, 5:42 AM

	Unknown Object (File)
	Tue, Dec 24, 12:22 AM

	Unknown Object (File)
	Mon, Dec 23, 8:59 AM

	Unknown Object (File)
	Fri, Dec 20, 10:16 PM

View All 41 Files

Subscribers

Details

Reviewers

kamil
varun
ashoat

Commits

rCOMM39f3157f8ad7: [lib][keyserver] Handle invalid CSAT in BlobOperationResult

Summary

Part of ENG-9526.

Depends on D13957, D13960

Test Plan

Manual testing with mocked invalid access token

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Nov 21 2024, 3:58 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 21 2024, 3:58 AM

bartek added a child revision: D13989: [lib][keyserver] Handle invalid CSAT on blob download.Nov 21 2024, 3:59 AM

Harbormaster failed remote builds in B32744: Diff 45919!Nov 21 2024, 4:13 AM

Fix eslint

Harbormaster completed remote builds in B32750: Diff 45925.Nov 21 2024, 4:56 AM

bartek published this revision for review.Nov 24 2024, 11:00 PM

bartek edited the test plan for this revision. (Show Details)Nov 24 2024, 11:24 PM

ashoat accepted this revision.Nov 25 2024, 5:33 AM

ashoat added inline comments.

lib/utils/services-utils.js
38 ↗	(On Diff #45925)	Can we name this something more specific? Either `blobResponseIsInvalidCSAT` or `httpResponseIsInvalidCSAT` would be good, I think

This revision is now accepted and ready to land.Nov 25 2024, 5:33 AM

bartek added inline comments.Nov 25 2024, 7:08 AM

lib/utils/services-utils.js
38 ↗	(On Diff #45925)	Yes, I'll do that. `httpResponseIsInvalidCSAT` sounds good

Rebase. Rename function to httpResponseIsInvalidCSAT

Harbormaster completed remote builds in B32840: Diff 46055.Nov 26 2024, 4:48 AM

Closed by commit rCOMM39f3157f8ad7: [lib][keyserver] Handle invalid CSAT in BlobOperationResult (authored by bartek). · Explain WhyFri, Nov 29, 5:03 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM39f3157f8ad7: [lib][keyserver] Handle invalid CSAT in BlobOperationResult.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

services/

22 lines

lib/

actions/

upload-actions.js

4 lines

utils/

blob-service.js

28 lines

services-utils.js

6 lines

Diff 45919

keyserver/src/services/blob.js

Loading...

lib/actions/upload-actions.js

Loading...

lib/utils/blob-service.js

Loading...

lib/utils/services-utils.js

Loading...