Page MenuHomePhabricator
Differential D13994

[native] community list item component
Needs RevisionPublic
Actions

Authored by varun on Thu, Nov 21, 9:51 AM.
Tags
None
Referenced Files
F3339970: D13994.id45931.diff
Thu, Nov 21, 9:05 PM
F3339969: D13994.id45930.diff
Thu, Nov 21, 9:05 PM
F3339968: D13994.id45929.diff
Thu, Nov 21, 9:05 PM
F3339962: D13994.id.diff
Thu, Nov 21, 9:05 PM
F3339957: D13994.diff
Thu, Nov 21, 9:05 PM
F3335850: RPReplay_Final1732217286.MP4
Thu, Nov 21, 11:30 AM
F3335598: Simulator Screen Recording - iPhone 16 Pro Max - 2024-11-21 at 13.04.19.mp4
Thu, Nov 21, 10:06 AM
Subscribers
tomek

Details

Reviewers
ashoat
Summary

Depends on D13987

https://linear.app/comm/issue/ENG-9897/communitylistitem-component

this component will be used in the CommunityList component that I introduce next

Test Plan

tested with later diffs (not yet published) and verified that join/leave work as expected. see video

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Thu, Nov 21, 9:51 AM
Herald added a subscriber: tomek. · View Herald TranscriptThu, Nov 21, 9:51 AM
varun updated this revision to Diff 45930.Thu, Nov 21, 9:54 AM

rearrange file

varun updated this revision to Diff 45931.Thu, Nov 21, 10:06 AM

fix activityIndicator location

varun edited the test plan for this revision. (Show Details)Thu, Nov 21, 10:06 AM
varun attached a referenced file: F3335598: Simulator Screen Recording - iPhone 16 Pro Max - 2024-11-21 at 13.04.19.mp4. (Show Details)
Harbormaster completed remote builds in B32754: Diff 45930.Thu, Nov 21, 10:15 AM
Harbormaster completed remote builds in B32753: Diff 45929.Thu, Nov 21, 10:17 AM
Harbormaster completed remote builds in B32755: Diff 45931.Thu, Nov 21, 10:23 AM
varun requested review of this revision.Thu, Nov 21, 10:23 AM
varun added a comment.Thu, Nov 21, 11:30 AM
This comment was removed by varun.
varun attached a referenced file: F3335850: RPReplay_Final1732217286.MP4. (Show Details)Thu, Nov 21, 11:30 AM
varun edited the test plan for this revision. (Show Details)
varun added a child revision: D13995: [native] introduce community list component.Thu, Nov 21, 1:41 PM
varun added a comment.Thu, Nov 21, 1:46 PM

the search bar placeholder text is in the following diff, where it is actually "Search communities" (see D13995)

ashoat requested changes to this revision.Thu, Nov 21, 6:50 PM

It looks like you got a lot of this from another file. If any of my feedback here applies to the original file, can you make sure to make the changes there too?

native/components/community-list-item.react.js
44–46 ↗(On Diff #45931)

What's the point of this, as opposed to just using the ThreadInfo we're passed?

61–64 ↗(On Diff #45931)

Can these be moved closer to where they're used?

139 ↗(On Diff #45931)

I'd like to iterate a bit on the design of the button here. Some thoughts:

  1. What do you think of using PrimaryButton, or perhaps building a more compact variation of it? I think it would look sleaker to have the rounded corners, and it gives us in-progress state for free
  2. I think it might look better right-aligned
  3. I'm not sure about the colors, they seem a little too basic
This revision now requires changes to proceed.Thu, Nov 21, 6:50 PM

Revision Contents
Changeset List

PathSize
native/
components/
178 lines

Diff 45929

View Options

native/components/community-list-item.react.js

Loading...