Page MenuHomePhabricator
Differential D14030

[keyserver] Handle invalid CSAT in Tunnelbroker socket
ClosedPublic
Actions

Authored by bartek on Nov 24 2024, 11:36 PM.
Tags
None
Referenced Files
F3540912: D14030.id46147.diff
Thu, Dec 26, 5:51 AM
F3540911: D14030.id46065.diff
Thu, Dec 26, 5:51 AM
F3540910: D14030.id45984.diff
Thu, Dec 26, 5:51 AM
F3540908: D14030.id46017.diff
Thu, Dec 26, 5:51 AM
F3540746: D14030.diff
Thu, Dec 26, 5:45 AM
Unknown Object (File)
Tue, Dec 24, 6:50 PM
Unknown Object (File)
Mon, Dec 23, 10:33 PM
Unknown Object (File)
Sat, Dec 21, 11:09 AM
View All 36 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
kamil
Commits
rCOMM4ff096b69971: [keyserver] Handle invalid CSAT in Tunnelbroker socket
Summary

Similiar to D13956 but for keyserver

Depends on D13956

Test Plan

Mocked connection inintialization message to have invalid token. Upon receiving response, the metadata table was cleared. Closing connection caused a retry, on which login was performed and new metadata was created.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Nov 24 2024, 11:36 PM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 24 2024, 11:36 PM
bartek added a child revision: D14031: [lib] Handle invalid CSAT in Identity Search context.Nov 24 2024, 11:37 PM
Harbormaster completed remote builds in B32797: Diff 45984.Nov 25 2024, 12:30 AM
bartek published this revision for review.Nov 25 2024, 2:08 AM
bartek added a parent revision: D13957: [keyserver] Add function to clear identity metadata.Nov 25 2024, 4:10 AM
bartek updated this revision to Diff 46017.Nov 25 2024, 4:24 AM

Improve retries

kamil accepted this revision.Nov 25 2024, 4:48 AM
This revision is now accepted and ready to land.Nov 25 2024, 4:48 AM
Harbormaster completed remote builds in B32812: Diff 46017.Nov 25 2024, 4:59 AM
ashoat added inline comments.Nov 25 2024, 7:07 AM
keyserver/src/socket/tunnelbroker.js
119

Confused a bit why this was moved out of createNewTunnelbrokerSocket.

We end up calling fetchIdentityInfo even if !encryptionKey. Is this intentional? If we move this call back into createNewTunnelbrokerSocket, then we could skip it in that case.

bartek added inline comments.Nov 26 2024, 4:39 AM
keyserver/src/socket/tunnelbroker.js
119

Intentional. Both ways would work, I just assumed my way was cleaner. But your suggestion makes sense as well, so I'll move it back.

bartek updated this revision to Diff 46065.Nov 26 2024, 4:45 AM

Rebase. Move fetchIdentityInfo back inside inner function

Harbormaster completed remote builds in B32850: Diff 46065.Nov 26 2024, 6:19 AM
Closed by commit rCOMM4ff096b69971: [keyserver] Handle invalid CSAT in Tunnelbroker socket (authored by bartek). · Explain WhyFri, Nov 29, 5:03 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM4ff096b69971: [keyserver] Handle invalid CSAT in Tunnelbroker socket.

Revision Contents
Changeset List

PathSize
keyserver/
src/
socket/
30 lines

Diff 46017

View Options

keyserver/src/socket/tunnelbroker.js

Loading...