[keyserver] Add function to clear identity metadata
AcceptedPublic
Actions

Authored by bartek on Mon, Nov 18, 6:50 AM.

Details

Reviewers

varun
kamil
ashoat

Summary

Partially addresses ENG-6545.
Added a function to clear user ID and access token from metadata table. It's going to be called when service authentication fails.

Test Plan

Called this function manually and verified in TablePlus that these rows were removed. Calling verifyUserLoggedIn() creates them again.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Mon, Nov 18, 6:50 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMon, Nov 18, 6:50 AM

Harbormaster completed remote builds in B32698: Diff 45864.Mon, Nov 18, 7:26 AM

bartek added a child revision: D13988: [lib][keyserver] Handle invalid CSAT in BlobOperationResult.Thu, Nov 21, 3:58 AM

bartek published this revision for review.Thu, Nov 21, 9:13 AM

varun accepted this revision.Thu, Nov 21, 11:09 AM

This revision is now accepted and ready to land.Thu, Nov 21, 11:09 AM

ashoat accepted this revision.Thu, Nov 21, 6:24 PM

ashoat added inline comments.

keyserver/src/user/identity.js
131 ↗	(On Diff #45864)	Nit: this query will crash if passed an empty array. We don't do that currently, but I've seen this accidentally happen enough times that I usually try to cover it
136 ↗	(On Diff #45864)	I think it would be better to return `Promise<void>`. The `QueryResult` type has some `any`s and you never seem to use it from any of the callsites of `clearMetadata` currently in this stack