[lib] Extract function to download blob
ClosedPublic
Actions

Authored by bartek on Nov 18 2024, 6:52 AM.

Details

Reviewers

kamil
varun
ashoat

Commits

rCOMMa53b50ff3481: [lib] Extract function to download blob

Summary

Preparation for ENG-9526.
Replaced direct calls of fetch() with a dedicated function. It makes it easier to handle specific response code for invalid CSAT.

Test Plan

Flow, eslint, manual testing

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Nov 18 2024, 6:52 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 18 2024, 6:52 AM

bartek added a child revision: D13959: [lib] Extract function to assign holder.Nov 18 2024, 6:52 AM

Harbormaster failed remote builds in B32699: Diff 45865!Nov 18 2024, 7:11 AM

Fix flow

Harbormaster completed remote builds in B32749: Diff 45924.Nov 21 2024, 4:58 AM

bartek published this revision for review.Nov 21 2024, 5:15 AM

varun accepted this revision.Nov 21 2024, 11:25 AM

This revision is now accepted and ready to land.Nov 21 2024, 11:25 AM

ashoat accepted this revision.Nov 21 2024, 4:39 PM

ashoat added inline comments.

lib/utils/blob-service.js
92 ↗	(On Diff #45924)	Inputs should (usually) be read-only

ashoat mentioned this in D13989: [lib][keyserver] Handle invalid CSAT on blob download.Mon, Nov 25, 5:40 AM

bartek added inline comments.Tue, Nov 26, 4:08 AM

lib/utils/blob-service.js
92 ↗	(On Diff #45924)	They're intentionally not read-only because `fetch` doesn't accept them this way, Util function `createDefaultHTTPRequestHeaders()` also returns them as mutable for this reason