[web] Handle invalid CSAT in Identity client
ClosedPublic
Actions

Authored by bartek on Nov 24 2024, 11:29 PM.

Details

Reviewers

kamil
varun

Commits

rCOMM346a9e52703e: [web] Handle invalid CSAT in Identity client

Summary

Part of ENG-6664
On web, we cannot use the same approach as on native because Identity calls are done on shared worker, while hook needs to be called on main context.

Depends on D14024

Test Plan

Manual testing with mocked invalid access token. Identity authed RPC calls end up with logout.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Nov 24 2024, 11:29 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 24 2024, 11:29 PM

Harbormaster completed remote builds in B32792: Diff 45979.Nov 24 2024, 11:46 PM

bartek published this revision for review.Nov 25 2024, 2:08 AM

kamil accepted this revision.Nov 25 2024, 5:10 AM

kamil added inline comments.

web/grpc/identity-service-context-provider.react.js
104 ↗	(On Diff #45979)	same feedback as in https://phab.comm.dev/D14024#inline-78766

This revision is now accepted and ready to land.Nov 25 2024, 5:10 AM

bartek added inline comments.Nov 26 2024, 4:33 AM

web/grpc/identity-service-context-provider.react.js
104 ↗	(On Diff #45979)	Answered there. The same applies for grpc-web - it behaves the same as our Rust Display traits. Exception message is the RPC error message (error code from Identity).