Page MenuHomePhabricator
Differential D13988

[lib][keyserver] Handle invalid CSAT in BlobOperationResult
ClosedPublic
Actions

Authored by bartek on Nov 21 2024, 3:58 AM.
Tags
None
Referenced Files
F3523338: D13988.id46055.diff
Mon, Dec 23, 8:59 AM
Unknown Object (File)
Fri, Dec 20, 10:16 PM
Unknown Object (File)
Wed, Dec 18, 7:24 PM
Unknown Object (File)
Mon, Dec 16, 2:22 AM
Unknown Object (File)
Mon, Dec 16, 2:22 AM
Unknown Object (File)
Fri, Dec 13, 9:38 PM
Unknown Object (File)
Fri, Dec 13, 8:12 PM
Unknown Object (File)
Fri, Dec 13, 1:27 PM
View All 35 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
varun
ashoat
Commits
rCOMM39f3157f8ad7: [lib][keyserver] Handle invalid CSAT in BlobOperationResult
Summary

Part of ENG-9526.

Depends on D13957, D13960

Test Plan

Manual testing with mocked invalid access token

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Nov 21 2024, 3:58 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 21 2024, 3:58 AM
bartek added a child revision: D13989: [lib][keyserver] Handle invalid CSAT on blob download.Nov 21 2024, 3:59 AM
Harbormaster failed remote builds in B32744: Diff 45919!Nov 21 2024, 4:13 AM
bartek updated this revision to Diff 45925.Nov 21 2024, 4:32 AM

Fix eslint

Harbormaster completed remote builds in B32750: Diff 45925.Nov 21 2024, 4:56 AM
bartek published this revision for review.Sun, Nov 24, 11:00 PM
bartek edited the test plan for this revision. (Show Details)Sun, Nov 24, 11:24 PM
ashoat accepted this revision.Mon, Nov 25, 5:33 AM
ashoat added inline comments.
lib/utils/services-utils.js
38 ↗(On Diff #45925)

Can we name this something more specific? Either blobResponseIsInvalidCSAT or httpResponseIsInvalidCSAT would be good, I think

This revision is now accepted and ready to land.Mon, Nov 25, 5:33 AM
bartek added inline comments.Mon, Nov 25, 7:08 AM
lib/utils/services-utils.js
38 ↗(On Diff #45925)

Yes, I'll do that. httpResponseIsInvalidCSAT sounds good

bartek updated this revision to Diff 46055.Tue, Nov 26, 4:13 AM

Rebase. Rename function to httpResponseIsInvalidCSAT

Harbormaster completed remote builds in B32840: Diff 46055.Tue, Nov 26, 4:48 AM
Closed by commit rCOMM39f3157f8ad7: [lib][keyserver] Handle invalid CSAT in BlobOperationResult (authored by bartek). · Explain WhyFri, Nov 29, 5:03 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM39f3157f8ad7: [lib][keyserver] Handle invalid CSAT in BlobOperationResult.

Revision Contents
Changeset List

PathSize
keyserver/
src/
services/
22 lines
lib/
actions/
20 lines
utils/
5 lines
32 lines
13 lines

Diff 46136

View Options

keyserver/src/services/blob.js

Loading...
View Options

lib/actions/upload-actions.js

Loading...
View Options

lib/utils/blob-service-upload.js

Loading...
View Options

lib/utils/blob-service.js

Loading...
View Options

lib/utils/services-utils.js

Loading...