Page MenuHomePhabricator

[native] add danger option to `PrimaryButton`
ClosedPublic

Authored by kamil on Thu, Dec 12, 11:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 28, 3:59 PM
Unknown Object (File)
Sat, Dec 28, 1:11 AM
Unknown Object (File)
Fri, Dec 27, 11:21 AM
Unknown Object (File)
Thu, Dec 26, 5:18 PM
Unknown Object (File)
Thu, Dec 26, 5:01 PM
Unknown Object (File)
Thu, Dec 26, 3:19 AM
Unknown Object (File)
Wed, Dec 25, 4:55 PM
Unknown Object (File)
Wed, Dec 25, 3:05 AM
Subscribers
None

Details

Summary

ENG-9959.

According to this we want a red Remove button so adding this config here.

I was trying to follow the approach we had in the codebase and was looking for patterns, but perhaps I broke some rules in how we should use colors, so sorry for that in advance.

Dark:

image.png (160×746 px, 15 KB)

Light:

image.png (150×736 px, 16 KB)

Example screen where this is used:

IMG_4790 (1).PNG (1×828 px, 57 KB)

Depends on D14149

Test Plan

Render button using dark and light theme

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage