Page MenuHomePhabricator
Differential D14116

[native] navigate to proper screen after scanning QR code
ClosedPublic
Actions

Authored by kamil on Wed, Dec 11, 8:17 AM.
Tags
None
Referenced Files
F3627827: D14116.diff
Thu, Jan 2, 3:37 PM
Unknown Object (File)
Sat, Dec 28, 3:27 PM
Unknown Object (File)
Sat, Dec 28, 12:37 AM
Unknown Object (File)
Sat, Dec 28, 12:35 AM
Unknown Object (File)
Fri, Dec 27, 3:21 PM
Unknown Object (File)
Fri, Dec 27, 2:48 PM
Unknown Object (File)
Fri, Dec 27, 6:22 AM
Unknown Object (File)
Fri, Dec 27, 4:14 AM
View All 33 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMM967d051bcffb: [native] navigate to proper screen after scanning QR code
Summary

ENG-9959.

Navigates to screen implemented in previous diffs in the stack, right after the QR code is scanned.

Adds useFocusEffect because after swiping back to the camera user should be able to scan the QR again.

In ENG-9968 there is an example of how this flow looks like

Depends on D14115

Test Plan

Test this on both secondary and primary, full flow should work.

After swiping back to the camera, the user can scan the QR code again.

Diff Detail

Repository
rCOMM Comm
Branch
land
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Wed, Dec 11, 8:17 AM
kamil held this revision as a draft.
kamil edited the summary of this revision. (Show Details)Wed, Dec 11, 8:25 AM
kamil added inline comments.
native/account/qr-auth/secondary-device-qr-code-scanner.react.js
63 ↗(On Diff #46334)

this is only for emulator but looks like we could also check if device is primary

kamil edited the summary of this revision. (Show Details)Wed, Dec 11, 8:26 AM
kamil edited the test plan for this revision. (Show Details)
kamil published this revision for review.Wed, Dec 11, 8:30 AM
Harbormaster completed remote builds in B33016: Diff 46334.Wed, Dec 11, 10:09 AM
ashoat accepted this revision.Thu, Dec 12, 11:03 AM
ashoat added inline comments.
native/account/qr-auth/secondary-device-qr-code-scanner.react.js
39 ↗(On Diff #46334)

I'd move this declaration lower, closer to where it's used

63 ↗(On Diff #46334)

Yes, I agree it would be good to check that here. Can you do that (either here or in a new diff) before landing?

This revision is now accepted and ready to land.Thu, Dec 12, 11:03 AM
kamil added a child revision: D14149: [native] implement screen after secondary device is connected.Thu, Dec 12, 11:10 AM
kamil updated this revision to Diff 46538.Tue, Dec 17, 4:43 AM

add primary check for simulator

Harbormaster failed remote builds in B33159: Diff 46538!Tue, Dec 17, 4:49 AM
Harbormaster completed remote builds in B33159: Diff 46538.Tue, Dec 17, 5:11 AM
Closed by commit rCOMM967d051bcffb: [native] navigate to proper screen after scanning QR code (authored by kamil). · Explain WhyTue, Dec 17, 7:06 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM967d051bcffb: [native] navigate to proper screen after scanning QR code.

Revision Contents
Changeset List

PathSize
native/
account/
qr-auth/
62 lines

Diff 46538

View Options

native/account/qr-auth/secondary-device-qr-code-scanner.react.js

Loading...