Paths

Table of Contentst

-
native/account/qr-auth/
-
account/
-
qr-auth/
-
connect-secondary-device.react.js
-
primary-device-q-r-auth-context-provider.js
-
primary-device-q-r-auth-context.js
-
qr-auth-context-provider.js
-
qr-auth-context.js
-
qr-auth-navigator.react.js
-
secondary-device-not-responding.react.js

[native] rename `QRAuthContext` to `PrimaryDeviceQRAuthContext`
ClosedPublic
Actions

Authored by kamil on Dec 18 2024, 5:08 AM.

Details

Reviewers

bartek
tomek

Commits

rCOMM158fc4fa3234: [native] rename `QRAuthContext` to `PrimaryDeviceQRAuthContext`

Summary

In D14105 I introduced context and it turned out, that what I added and existing context on the secondary side have the same names, to avoid confusion I am renaming them to SecondaryDeviceQRAuthContext and PrimaryDeviceQRAuthContext.

Depends on D14166

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Branch

fixes

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Dec 18 2024, 5:08 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptDec 18 2024, 5:08 AM

kamil added a child revision: D14170: [native] rename `<Registration*` components to `<Auth*` components.Dec 18 2024, 5:20 AM

Harbormaster completed remote builds in B33172: Diff 46566.Dec 18 2024, 6:09 AM

kamil edited the summary of this revision. (Show Details)Dec 19 2024, 2:00 AM

fix typo

Harbormaster completed remote builds in B33180: Diff 46576.Dec 19 2024, 2:32 AM

kamil published this revision for review.Dec 19 2024, 2:40 AM

bartek accepted this revision.Dec 19 2024, 5:18 AM

This revision is now accepted and ready to land.Dec 19 2024, 5:18 AM

Closed by commit rCOMM158fc4fa3234: [native] rename `QRAuthContext` to `PrimaryDeviceQRAuthContext` (authored by kamil). · Explain WhyJan 9 2025, 4:16 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM158fc4fa3234: [native] rename `QRAuthContext` to `PrimaryDeviceQRAuthContext`.

Revision Contents
Changeset List

Path

Size

native/

account/

qr-auth/

connect-secondary-device.react.js

13 lines

	primary-device-q-r-auth-context-provider.js
	qr-auth-context-provider.js

10 lines

primary-device-q-r-auth-context.js

14 lines

qr-auth-context-provider.js

qr-auth-context.js

qr-auth-navigator.react.js

6 lines

secondary-device-not-responding.react.js

13 lines

Diff 46566

View Options

native/account/qr-auth/connect-secondary-device.react.js