Page MenuHomePhabricator
Differential D14516

[SQLite] refactor `backedUpTablesBlocklist` to be allowlist approach
ClosedPublic
Actions

Authored by kamil on Thu, Apr 3, 2:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 19, 2:06 PM
Unknown Object (File)
Fri, Apr 18, 10:37 PM
Unknown Object (File)
Thu, Apr 17, 1:19 PM
Unknown Object (File)
Tue, Apr 15, 1:57 PM
Unknown Object (File)
Mon, Apr 14, 8:01 PM
Unknown Object (File)
Mon, Apr 14, 7:40 PM
Unknown Object (File)
Mon, Apr 14, 6:38 PM
Unknown Object (File)
Mon, Apr 14, 1:05 PM
View All 21 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
Commits
rCOMM709bb9123ee5: [SQLite] refactor `backedUpTablesBlocklist` to be allowlist approach
Summary

ENG-10463.

Depends on D14515

Test Plan

Upload compaction and make sure it contains only tables included in backedUpTablesAllowlist

Diff Detail

Repository
rCOMM Comm
Branch
backup-publish
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Thu, Apr 3, 2:22 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Apr 3, 2:22 AM
kamil edited the summary of this revision. (Show Details)Thu, Apr 3, 2:27 AM
kamil added a parent revision: D14515: [SQLite] add logging to `handleSQLiteError`.
kamil added a child revision: D14517: [SQLite] implement method to copy table between databases.Thu, Apr 3, 2:37 AM
Harbormaster completed remote builds in B33871: Diff 47621.Thu, Apr 3, 2:40 AM
kamil published this revision for review.Thu, Apr 3, 3:05 AM
kamil added inline comments.
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
43–51

This is only set for testing purposes now, it will be replaced with new tables after Stop backing up thin thread data

bartek accepted this revision.Thu, Apr 3, 3:27 AM
bartek added inline comments.
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
3118–3125

👍 for replacing string concat with stringstream

This revision is now accepted and ready to land.Thu, Apr 3, 3:27 AM
Closed by commit rCOMM709bb9123ee5: [SQLite] refactor `backedUpTablesBlocklist` to be allowlist approach (authored by kamil). · Explain WhyMon, Apr 7, 3:30 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM709bb9123ee5: [SQLite] refactor `backedUpTablesBlocklist` to be allowlist approach.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
4 lines
71 lines

Diff 47621

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...