native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
3313	We need to use this only on not-encrypted databases, see next diff in the stack
3317	We want `OR IGNORE` statement to skip duplicated primary keys, the example is a thread with Ashoat, which is created for each user (we won't include thin thread data in backup, but we do now, so without this each copy statement could fail)
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h
58	We might want to have a custom copy method (by specifying fields), e.g. for messages where we have one generated column

Don't we want this method to take a vector of tables to copy? Looking at D14519, I see you're running this in a loop, so the ATTACH DATABASE ..., DETACH statements are repeated for each table

In D14517#403050, @bartek wrote:

Don't we want this method to take a vector of tables to copy? Looking at D14519, I see you're running this in a loop, so the ATTACH DATABASE ..., DETACH statements are repeated for each table

Good call

address review

Harbormaster completed remote builds in B33889: Diff 47639.Thu, Apr 3, 5:39 AM

bartek accepted this revision.Thu, Apr 3, 7:25 AM

This revision is now accepted and ready to land.Thu, Apr 3, 7:25 AM

Closed by commit rCOMM277bd9ad9879: [SQLite] implement method to copy table between databases (authored by kamil). · Explain WhyMon, Apr 7, 3:30 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM277bd9ad9879: [SQLite] implement method to copy table between databases.