Page MenuHomePhabricator
Differential D14524

[lib][native] remove `performBackupRestore` from `SecondaryDeviceQRAuthContextProvider`
ClosedPublic
Actions

Authored by kamil on Thu, Apr 3, 3:30 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 18, 10:57 PM
Unknown Object (File)
Tue, Apr 15, 10:37 PM
Unknown Object (File)
Tue, Apr 15, 10:40 AM
Unknown Object (File)
Mon, Apr 14, 9:54 PM
Unknown Object (File)
Mon, Apr 14, 2:52 PM
Unknown Object (File)
Sun, Apr 13, 12:15 PM
Unknown Object (File)
Sun, Apr 13, 5:57 AM
Unknown Object (File)
Fri, Apr 11, 4:11 AM
View All 23 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
Commits
rCOMMfc46d98e8b94: [lib][native] remove `performBackupRestore` from…
Summary

Part of ENG-10477

This is now part of SQLiteAPI.

Depends on D14523

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Branch
backup-publish
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
components/
2 lines
native/
2 lines
utils/
17 lines

Diff 47629

View Options

lib/components/secondary-device-qr-auth-context-provider.react.js

Show First 20 Lines • Show All 56 Lines • ▼ Show 20 Linesexport const updateRelationshipMessageSpec: UpdateRelationshipMessageSpec =
Object.freeze({ Object.freeze({
messageContentForServerDB( messageContentForServerDB(
data: data:
| LegacyUpdateRelationshipMessageData | LegacyUpdateRelationshipMessageData
| RawLegacyUpdateRelationshipMessageInfo | RawLegacyUpdateRelationshipMessageInfo
| UpdateRelationshipMessageData | UpdateRelationshipMessageData
| RawUpdateRelationshipMessageInfo, | RawUpdateRelationshipMessageInfo,
): string { ): string {
if (
data.type === messageTypes.UPDATE_RELATIONSHIP &&
tomekUnsubmitted
Not Done
Inline Actions

Do we have to check this condition?

tomek: Do we have to check this condition?
atulAuthorUnsubmitted
Done
Inline Actions

Yeah, the reason we need to check this is because updateRelationshipMessageSpec is used for both LEGACY_UPDATE_RELATIONSHIP and UPDATE_RELATIONSHIP messages.

atul: Yeah, the reason we need to check this is because `updateRelationshipMessageSpec` is used for…
atulAuthorUnsubmitted
Done
Inline Actions

JK, I think what you're saying is that data.operation === 'farcaster_mutual' would be a sufficient check since that implicitly tells us that the message type is UPDATE_RELATIONSHIP so having both is a bit redundant.

Personally prefer including the first clause since it makes things more clear IMO, but can remove if others feel otherwise

atul: JK, I think what you're saying is that `data.operation === 'farcaster_mutual'` would be a…
tomekUnsubmitted
Not Done
Inline Actions

Ok, we can keep both conditions.

tomek: Ok, we can keep both conditions.
data.operation === 'farcaster_mutual'
) {
return JSON.stringify({
operation: data.operation,
targetID: data.targetID,
creatorFID: data.creatorFID,
targetFID: data.targetFID,
});
}
return JSON.stringify({ return JSON.stringify({
operation: data.operation, operation: data.operation,
targetID: data.targetID, targetID: data.targetID,
}); });
}, },
messageContentForClientDB( messageContentForClientDB(
data: data:
▲ Show 20 Lines • Show All 238 Lines • Show Last 20 Lines
View Options

native/root.react.js

Show First 20 Lines • Show All 56 Lines • ▼ Show 20 Linesexport const updateRelationshipMessageSpec: UpdateRelationshipMessageSpec =
Object.freeze({ Object.freeze({
messageContentForServerDB( messageContentForServerDB(
data: data:
| LegacyUpdateRelationshipMessageData | LegacyUpdateRelationshipMessageData
| RawLegacyUpdateRelationshipMessageInfo | RawLegacyUpdateRelationshipMessageInfo
| UpdateRelationshipMessageData | UpdateRelationshipMessageData
| RawUpdateRelationshipMessageInfo, | RawUpdateRelationshipMessageInfo,
): string { ): string {
if (
data.type === messageTypes.UPDATE_RELATIONSHIP &&
tomekUnsubmitted
Not Done
Inline Actions

Do we have to check this condition?

tomek: Do we have to check this condition?
atulAuthorUnsubmitted
Done
Inline Actions

Yeah, the reason we need to check this is because updateRelationshipMessageSpec is used for both LEGACY_UPDATE_RELATIONSHIP and UPDATE_RELATIONSHIP messages.

atul: Yeah, the reason we need to check this is because `updateRelationshipMessageSpec` is used for…
atulAuthorUnsubmitted
Done
Inline Actions

JK, I think what you're saying is that data.operation === 'farcaster_mutual' would be a sufficient check since that implicitly tells us that the message type is UPDATE_RELATIONSHIP so having both is a bit redundant.

Personally prefer including the first clause since it makes things more clear IMO, but can remove if others feel otherwise

atul: JK, I think what you're saying is that `data.operation === 'farcaster_mutual'` would be a…
tomekUnsubmitted
Not Done
Inline Actions

Ok, we can keep both conditions.

tomek: Ok, we can keep both conditions.
data.operation === 'farcaster_mutual'
) {
return JSON.stringify({
operation: data.operation,
targetID: data.targetID,
creatorFID: data.creatorFID,
targetFID: data.targetFID,
});
}
return JSON.stringify({ return JSON.stringify({
operation: data.operation, operation: data.operation,
targetID: data.targetID, targetID: data.targetID,
}); });
}, },
messageContentForClientDB( messageContentForClientDB(
data: data:
▲ Show 20 Lines • Show All 238 Lines • Show Last 20 Lines
View Options

native/utils/qr-code-utils.js

Show First 20 Lines • Show All 56 Lines • ▼ Show 20 Linesexport const updateRelationshipMessageSpec: UpdateRelationshipMessageSpec =
Object.freeze({ Object.freeze({
messageContentForServerDB( messageContentForServerDB(
data: data:
| LegacyUpdateRelationshipMessageData | LegacyUpdateRelationshipMessageData
| RawLegacyUpdateRelationshipMessageInfo | RawLegacyUpdateRelationshipMessageInfo
| UpdateRelationshipMessageData | UpdateRelationshipMessageData
| RawUpdateRelationshipMessageInfo, | RawUpdateRelationshipMessageInfo,
): string { ): string {
if (
data.type === messageTypes.UPDATE_RELATIONSHIP &&
tomekUnsubmitted
Not Done
Inline Actions

Do we have to check this condition?

tomek: Do we have to check this condition?
atulAuthorUnsubmitted
Done
Inline Actions

Yeah, the reason we need to check this is because updateRelationshipMessageSpec is used for both LEGACY_UPDATE_RELATIONSHIP and UPDATE_RELATIONSHIP messages.

atul: Yeah, the reason we need to check this is because `updateRelationshipMessageSpec` is used for…
atulAuthorUnsubmitted
Done
Inline Actions

JK, I think what you're saying is that data.operation === 'farcaster_mutual' would be a sufficient check since that implicitly tells us that the message type is UPDATE_RELATIONSHIP so having both is a bit redundant.

Personally prefer including the first clause since it makes things more clear IMO, but can remove if others feel otherwise

atul: JK, I think what you're saying is that `data.operation === 'farcaster_mutual'` would be a…
tomekUnsubmitted
Not Done
Inline Actions

Ok, we can keep both conditions.

tomek: Ok, we can keep both conditions.
data.operation === 'farcaster_mutual'
) {
return JSON.stringify({
operation: data.operation,
targetID: data.targetID,
creatorFID: data.creatorFID,
targetFID: data.targetFID,
});
}
return JSON.stringify({ return JSON.stringify({
operation: data.operation, operation: data.operation,
targetID: data.targetID, targetID: data.targetID,
}); });
}, },
messageContentForClientDB( messageContentForClientDB(
data: data:
▲ Show 20 Lines • Show All 238 Lines • Show Last 20 Lines