Differential D3077

[services] Backup - reset implementation
ClosedPublic
Actions

Authored by • karol on Feb 3 2022, 6:47 AM.

Tags

None

Referenced Files

	F3354794: D3077.id9207.diff
	Sat, Nov 23, 1:17 PM

	F3354143: D3077.diff
	Sat, Nov 23, 12:01 PM

	Unknown Object (File)
	Tue, Nov 12, 12:14 AM

	Unknown Object (File)
	Thu, Oct 31, 7:21 PM

	Unknown Object (File)
	Sun, Oct 27, 4:02 AM

	Unknown Object (File)
	Oct 16 2024, 3:49 AM

	Unknown Object (File)
	Oct 16 2024, 3:49 AM

	Unknown Object (File)
	Oct 16 2024, 3:49 AM

Subscribers

Details

Reviewers

• max
tomek
varun
ashoat

Commits

rCOMM8d04c25f1bc2: [services] Backup - reset implementation

Summary

The new API of the backup service will be significantly different from the current one, so I decided to simply remove everything. It's still going to be in the git history so we can get back to it any time but removing it will make testing and implementation process easier.

Test Plan

-

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Feb 3 2022, 6:47 AM

Herald added subscribers: atul, • adrian, tomek, ashoat. · View Herald TranscriptFeb 3 2022, 6:47 AM

• karol edited the summary of this revision. (Show Details)Feb 3 2022, 6:57 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: • max, tomek, varun.

• karol published this revision for review.Feb 3 2022, 7:01 AM

Harbormaster completed remote builds in B6475: Diff 9207.Feb 3 2022, 8:06 AM

If you think there's no value in comparing the old implementation with the new one, this makes sense

This revision is now accepted and ready to land.Feb 4 2022, 2:31 AM

Herald added a reviewer: ashoat. · View Herald TranscriptFeb 4 2022, 2:31 AM

Herald added a subscriber: • benschac. · View Herald Transcript

This revision now requires review to proceed.Feb 4 2022, 2:31 AM

ashoat accepted this revision.Feb 5 2022, 12:31 PM

This revision is now accepted and ready to land.Feb 5 2022, 12:31 PM

• karol edited the summary of this revision. (Show Details)Feb 8 2022, 1:22 AM

• karol added a parent revision: D3076: [services] Backup - redesign proto.

• karol added a child revision: D3078: [services] Backup - remove files for S3 operations.

In D3077#81626, @palys-swm wrote:

If you think there's no value in comparing the old implementation with the new one, this makes sense

I think it would take more time to figure out all the common parts than actually slaughter everything and start from scratch.

• karol edited the summary of this revision. (Show Details)Feb 8 2022, 1:46 AM

Closed by commit rCOMM8d04c25f1bc2: [services] Backup - reset implementation (authored by • karol). · Explain WhyFeb 8 2022, 1:49 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM8d04c25f1bc2: [services] Backup - reset implementation.

Revision Contents
Changeset List

Path

Size

services/

backup/

docker-server/

contents/

server/

src/

BackupServiceImpl.h

33 lines

BackupServiceImpl.cpp

158 lines

Diff 9207

services/backup/docker-server/contents/server/src/BackupServiceImpl.h

Loading...

services/backup/docker-server/contents/server/src/BackupServiceImpl.cpp

Loading...