Differential D3079

[services] Backup - add constants
ClosedPublic
Actions

Authored by • karol on Feb 3 2022, 6:48 AM.

Tags

None

Referenced Files

	F3378105: D3079.id9432.diff
	Wed, Nov 27, 8:58 AM

	F3377809: D3079.id9362.diff
	Wed, Nov 27, 7:37 AM

	Unknown Object (File)
	Oct 27 2024, 4:02 AM

	Unknown Object (File)
	Oct 23 2024, 9:52 AM

	Unknown Object (File)
	Oct 21 2024, 1:57 AM

	Unknown Object (File)
	Oct 21 2024, 1:57 AM

	Unknown Object (File)
	Oct 21 2024, 1:57 AM

	Unknown Object (File)
	Oct 20 2024, 8:27 PM

Subscribers

Details

Reviewers

tomek
• max
varun
ashoat
• jim

Commits

rCOMM6bdcf54ff77d: [services] Backup - add constants

Summary

Constant values for the backup service

Test Plan

-

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Feb 3 2022, 6:48 AM

Herald added subscribers: atul, • adrian, tomek, ashoat. · View Herald TranscriptFeb 3 2022, 6:48 AM

• karol published this revision for review.Feb 3 2022, 7:04 AM

• karol edited the summary of this revision. (Show Details)

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, • max, varun.

Harbormaster completed remote builds in B6477: Diff 9209.Feb 3 2022, 8:19 AM

tomek requested changes to this revision.Feb 4 2022, 2:41 AM

tomek added inline comments.

services/backup/docker-server/contents/server/src/Constants.h
23	Do we need multipart upload size? We removed all the S3 related stuff in the previous diff?
25	Do we need this?
27–31	I guess there should be a couple of tables here, not just this one

This revision now requires changes to proceed.Feb 4 2022, 2:41 AM

• karol edited the summary of this revision. (Show Details)Feb 8 2022, 1:23 AM

• karol edited the summary of this revision. (Show Details)

• karol added a parent revision: D3078: [services] Backup - remove files for S3 operations.

• karol added a child revision: D3080: [services] Backup - add AWS Tools.

• karol added inline comments.Feb 8 2022, 1:30 AM

services/backup/docker-server/contents/server/src/Constants.h
23	To be removed, thanks.
25	I'm going to go with this for now and fix this separately. The solution @geekbrother proposed for tunnelbroker is not fully valid in my opinion - https://linear.app/comm/issue/ENG-559/removing-aws-region-from-constants
27–31	This is going to be removed and added in the following diffs

update

Harbormaster completed remote builds in B6606: Diff 9362.Feb 8 2022, 1:36 AM

• karol edited the summary of this revision. (Show Details)Feb 8 2022, 1:46 AM

tomek accepted this revision.Feb 8 2022, 7:24 AM

This revision is now accepted and ready to land.Feb 8 2022, 7:24 AM

Herald added a reviewer: ashoat. · View Herald TranscriptFeb 8 2022, 7:24 AM

Herald added a subscriber: • benschac. · View Herald Transcript

This revision now requires review to proceed.Feb 8 2022, 7:24 AM

ashoat accepted this revision.Feb 8 2022, 8:10 PM

ashoat added a reviewer: • jim.

This revision is now accepted and ready to land.Feb 8 2022, 8:10 PM

Closed by commit rCOMM6bdcf54ff77d: [services] Backup - add constants (authored by • karol). · Explain WhyFeb 9 2022, 12:24 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM6bdcf54ff77d: [services] Backup - add constants.

Revision Contents
Changeset List

Path

Size

services/

backup/

docker-server/

contents/

server/

src/

34 lines

Diff 9209

services/backup/docker-server/contents/server/src/Constants.h

Loading...

services/backup/docker-server/contents/server/src/Tools.h

Loading...