services/backup/docker-server/contents/server/src/DatabaseEntities/DatabaseEntitiesTools.h
3	Is it created later in this stack or something from the old implementation?
27	There are some questions regarding this in D2950, but for now this is consistent with the current state

This revision is now accepted and ready to land.Feb 4 2022, 2:46 AM

Herald added a reviewer: ashoat. · View Herald TranscriptFeb 4 2022, 2:46 AM

Herald added a subscriber: • benschac. · View Herald Transcript

This revision now requires review to proceed.Feb 4 2022, 2:46 AM

Passing back to update the database structure with your new schema

This revision now requires changes to proceed.Feb 5 2022, 1:08 PM

• karol edited the summary of this revision. (Show Details)Feb 8 2022, 1:24 AM

• karol added a parent revision: D3080: [services] Backup - add AWS Tools.

• karol added a child revision: D3082: [services] Backup - add Database Manager base.

update

• karol edited the summary of this revision. (Show Details)Feb 8 2022, 1:46 AM

Harbormaster completed remote builds in B6608: Diff 9364.Feb 8 2022, 1:53 AM

tomek accepted this revision.Feb 8 2022, 8:02 AM

So it's easier to land this, and so we don't block this on the architecture review, maybe you should remove the comment for now and add it back later after the architecture review is finalized?

services/backup/docker-server/contents/server/src/DatabaseEntities/DatabaseEntitiesTools.h
18–19 ↗	(On Diff #9364)	I think we can combine these, right? Is there any reason not to?

This revision is now accepted and ready to land.Feb 8 2022, 8:13 PM

ashoat added a reviewer: • jim.Feb 8 2022, 8:13 PM

In D3081#83141, @ashoat wrote:

So it's easier to land this, and so we don't block this on the architecture review, maybe you should remove the comment for now and add it back later after the architecture review is finalized?

We can do that