Parent class for all database items
Details
Details
Summary
Test Plan
-
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Herald added subscribers: atul, • adrian, tomek, ashoat. · View Herald TranscriptFeb 3 2022, 6:49 AM2022-02-03 06:49:33 (UTC-8)
Harbormaster completed remote builds in B6481: Diff 9213.Feb 3 2022, 8:37 AM2022-02-03 08:37:55 (UTC-8)
This revision is now accepted and ready to land.Feb 7 2022, 3:16 AM2022-02-07 03:16:11 (UTC-8)
Herald added a reviewer: ashoat. · View Herald TranscriptFeb 7 2022, 3:16 AM2022-02-07 03:16:11 (UTC-8)
This revision now requires review to proceed.Feb 7 2022, 3:16 AM2022-02-07 03:16:11 (UTC-8)
This revision is now accepted and ready to land.Feb 7 2022, 9:45 AM2022-02-07 09:45:42 (UTC-8)
• karol edited the summary of this revision. (Show Details)Feb 8 2022, 1:25 AM2022-02-08 01:25:27 (UTC-8)
• karol edited the summary of this revision. (Show Details)Feb 8 2022, 1:37 AM2022-02-08 01:37:40 (UTC-8)
• karol edited the summary of this revision. (Show Details)Feb 8 2022, 1:46 AM2022-02-08 01:46:46 (UTC-8)
Harbormaster completed remote builds in B6607: Diff 9363.Feb 8 2022, 1:48 AM2022-02-08 01:48:57 (UTC-8)
Closed by commit rCOMM035dcc8fa6be: [services] Backup - Database - add Item (authored by • karol). · Explain WhyFeb 8 2022, 1:53 AM2022-02-08 01:53:11 (UTC-8)
This revision was automatically updated to reflect the committed changes.
I'd feel safer if this pickling key was less deterministic, but on the other hand I'm not sure if it is possible for someone to acquire only the pickled account without the key. If an attacker has both, then key security doesn't matter. So we can probably keep the current approach.