Reuse innerRemoveItem for BackupItem`s and LogItems
Depends on D3177
Details
Details
cd services yarn test-backup-service
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| services/backup/docker-server/contents/server/src/DatabaseManager.cpp | ||
|---|---|---|
| 33–36 | This is really confusing. On one hand, we use PrimaryKey to describe db structure by having column names in it. And now, we use the same object to store primary key value. We should instead add a method to Item e.g. getPrimaryKeyValue and use this method here. And I think we should have separate types for PrimaryKey and PrimaryKeyValue just to avoid them being confused with each other. | |
| services/backup/docker-server/contents/server/src/DatabaseManager.cpp | ||
|---|---|---|
| 33–36 | When I was writing this code I realized this can be confusing. Didn't really have an idea on how to overcome this. We can do getPrimaryKeyValue and also "separate" these types: PrimaryKey and PrimaryKeyValue. My idea is that they can be the same but have different names just to make it more clear. | |
| services/backup/docker-server/contents/server/src/DatabaseManager.cpp | ||
|---|---|---|
| 31–37 ↗ | (On Diff #9604) | Can't we just take primaryKeyValue from the item? |
| services/backup/docker-server/contents/server/src/DatabaseManager.cpp | ||
|---|---|---|
| 31–37 ↗ | (On Diff #9604) | Yes! Thanks! |