Page MenuHomePhabricator
Differential D3199

[services] Blob - remove redundant glob from CMakeLists.txt
AbandonedPublic
Actions

Authored by • karol on Feb 15 2022, 5:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 23, 3:09 AM
Unknown Object (File)
Sun, Oct 13, 5:11 PM
Unknown Object (File)
Sun, Oct 13, 5:11 PM
Unknown Object (File)
Sun, Oct 13, 5:08 PM
Unknown Object (File)
Sep 13 2024, 1:34 AM
Unknown Object (File)
Sep 3 2024, 1:25 PM
Unknown Object (File)
Sep 3 2024, 1:24 PM
Unknown Object (File)
Sep 3 2024, 1:22 PM
View All 80 Files
Subscribers
• adrian
ashoat
atul
• benschac
tomek

Details

Reviewers
tomek
• max
varun
ashoat
• jim
Summary

I spotted that there is a redundant glob in the blob's cmake.

Depends on D3198

Test Plan
cd services
yarn run-blob-service-dev-mode
yarn test-blob-service-dev-mode

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.Feb 15 2022, 5:18 AM
Herald added subscribers: atul, • adrian, tomek, ashoat. · View Herald TranscriptFeb 15 2022, 5:18 AM
• karol published this revision for review.Feb 15 2022, 5:27 AM
• karol edited the summary of this revision. (Show Details)
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, • max, varun.
• karol added a parent revision: D3198: [services] Move folly from Blob to Backup base.
• karol added a child revision: D3200: [services] Backup - dev mode.
Harbormaster completed remote builds in B6824: Diff 9663.Feb 15 2022, 5:42 AM
ashoat accepted this revision.Feb 15 2022, 7:44 PM
ashoat added a reviewer: • jim.
This revision is now accepted and ready to land.Feb 15 2022, 7:44 PM
Herald added a subscriber: • benschac. · View Herald TranscriptFeb 15 2022, 7:44 PM
tomek requested changes to this revision.Feb 16 2022, 5:31 AM
tomek added inline comments.
services/blob/docker-server/contents/server/CMakeLists.txt
37–41

I think that SOURCE_CODE and DEV_SOURCE_CODE should be related, so if we have ./src/**/*.cpp in source code, shouldn't we keep ./src/**/*.dev.cpp?

This revision now requires changes to proceed.Feb 16 2022, 5:31 AM
• karol requested review of this revision.Feb 18 2022, 5:30 AM
• karol added inline comments.
services/blob/docker-server/contents/server/CMakeLists.txt
37–41

Maybe that's the reason that this value is here. If you think we need this, we can always abandon the diff, just wanted to point out that it's redundant as no files matching this glob exist.

tomek accepted this revision.Feb 21 2022, 5:20 AM
tomek added inline comments.
services/blob/docker-server/contents/server/CMakeLists.txt
37–41

Up to you. It doesn't hurt to keep it and it will make it easier to add new dev code, but we can also delete this.

This revision is now accepted and ready to land.Feb 21 2022, 5:20 AM
• karol abandoned this revision.Feb 21 2022, 8:51 AM

Ok, abandoning

Revision Contents
Changeset List

PathSize
services/
blob/
docker-server/
contents/
server/
2 lines

Diff 9663

View Options

services/blob/docker-server/contents/server/CMakeLists.txt

Loading...