rename classes from color to actions

rebase

fix logic

I don't think I need this, will probably close diff.

In D3500#95581, @palys-swm wrote:

Not sure about this change - it is an improvement comparing to black, but still we can make this a lot better. The problem is, when we will be introducing another theme, we're going to change css variables. We have a nice abstraction that we're using --fg instead of white but that doesn't matter when we use it in a .white class. We should instead keep it more general. Ultimately, what is the benefit of having e.g. --fg when we're hardcoding it's value as a name of a class?

The proper solution here would be to have two classes .unread and .read which should assign proper color --fg, --thread-color-read or --thread-from-color-read.

commit squashed into D3500

squash commit

back to atul for review.

In D3480#94936, @atul wrote:

Certainly looks closer to what's on Figma, but it looks like there's too much vertical space between elements? It might be that the thread title is lowercase so it's not taking up the same vertical space as the examples?

In D3509#95333, @ashoat wrote:

This is fine as a ternary, in my opinion. See my comment here

Okay, it seemed like a bit much. I'll abandon this diff.

Closing this diff in favor of my refactor stack.

Normally the kind of thing I'd apply to every element in a CSS reset or something similar. Because we don't have a reset for web doing something like this:

Not ready for review

remove array

In D3503#95206, @atul wrote:

can you add these changes to https://phabricator.ashoat.com/D3500

remove hasUsername const

make hasUserName const

add missing class

In D3493#95153, @atul wrote:

N/A - should get any flow error

nit: think you mean *shouldn't?

adding ashoat as a reviewer since we ah-hoc designed mark as unread and want this to be in your queue. Feel free to remove yourself if it's not relevant.

add space

In D3422#94966, @ashoat wrote:

Not super clear why I'm being added to the review... I thought you just wanted my opinion on the different designs, which I gave above.

In the future, can you please make your intentions clear for short-circuiting the standard review process? There are plenty of good reasons to do this, but I can't tell what the reason is here.

D3422 handles the mark as unread styling.

@ashoat - no code changes. Just putting this in your queue to get input on the updated background color options.

@ashoat -- updated colors of the mark as unread button based off of D3421 changes to hover and selected state. We currently don't have design for mark as unread (because the previous diff flips the hover and selection colors from what's in figma).

In D3421#94707, @ashoat wrote:

The gif doesn't cover the mark-as-unread button. Can you share a screenshot to confirm that the contrast looks good?

Italics aren't defined anywhere in the Figma files. I'm fine keeping them if you think it's helpful.

Adding a gif here @ashoat -- I'm pretty sure we're on the same page with UX / what the selected color / hover color should be but just want to be sure.

update hover and selected state

add wrench

In D3440#94126, @ashoat wrote:

Not sure as to the details here, but we've previously discussed that the line connecting the sidebars should be continuous. At some point @benschac landed a diff that hacked the height in order to result in a continuous line. The height hack should be resolved in ENG-766.

In D3458#94127, @ashoat wrote:

Unacceptable diff name