Page MenuHomePhabricator
Feed Advanced Search

Apr 4 2022

jacek added a comment to D3566: [lib] New action to fetch single message for a list of threads.

I tested it in "Thread subchannels" modal and the action seems to work correctly

Apr 4 2022, 10:36 AM
jacek updated the diff for D3601: [web] Fetch preview messages from non-watched threads in thread subchannels modal.

Refactor some code & fix logic

Apr 4 2022, 9:39 AM
jacek added inline comments to D3601: [web] Fetch preview messages from non-watched threads in thread subchannels modal.
Apr 4 2022, 9:39 AM
jacek updated the diff for D3600: [web] Introduce `SubchannelsModal`.

use SearchModal & improvements after review

Apr 4 2022, 6:36 AM
jacek updated the diff for D3599: [web] Introduce `Subchannel` component.

rebase & fix css & fix ReadOnly

Apr 4 2022, 6:32 AM
jacek retitled D3597: [web] [lib] Introduce `getMessagePreview` function from [web] [lib] Introduce `useMessagePreview` hook to [web] [lib] Introduce `getMessagePreview` function.
Apr 4 2022, 6:18 AM
jacek updated the diff for D3597: [web] [lib] Introduce `getMessagePreview` function.

Changed the hook into plain function

Apr 4 2022, 6:17 AM
jacek accepted D3494: [web] Introduce search modal component.
Apr 4 2022, 6:15 AM
jacek added inline comments to D3599: [web] Introduce `Subchannel` component.
Apr 4 2022, 4:37 AM
jacek planned changes to D3601: [web] Fetch preview messages from non-watched threads in thread subchannels modal.
Apr 4 2022, 3:20 AM
jacek added inline comments to D3601: [web] Fetch preview messages from non-watched threads in thread subchannels modal.
Apr 4 2022, 3:20 AM

Apr 1 2022

jacek requested review of D3602: [web] Introduce `Subchannels` action in thread menu.
Apr 1 2022, 8:07 AM
jacek requested review of D3601: [web] Fetch preview messages from non-watched threads in thread subchannels modal.
Apr 1 2022, 8:00 AM
jacek requested review of D3600: [web] Introduce `SubchannelsModal`.
Apr 1 2022, 7:53 AM
jacek requested review of D3599: [web] Introduce `Subchannel` component.
Apr 1 2022, 7:46 AM
jacek added reviewers for D3597: [web] [lib] Introduce `getMessagePreview` function: benschac, atul.
Apr 1 2022, 7:38 AM
jacek requested review of D3598: [lib] Introduce `useFilteredChatListData` hook.
Apr 1 2022, 7:32 AM
jacek requested review of D3597: [web] [lib] Introduce `getMessagePreview` function.
Apr 1 2022, 7:26 AM
jacek closed D3490: [lib] Create common logic for filtering available thread members actions.
Apr 1 2022, 3:51 AM
jacek committed rCOMM8115a97a7eae: [lib] Create common logic for filtering available thread members actions (authored by jacek).
[lib] Create common logic for filtering available thread members actions
Apr 1 2022, 3:51 AM
jacek closed D3479: [web] Use SWM Icons in `Menu` component.
Apr 1 2022, 3:51 AM
jacek committed rCOMM32e90a2be054: [web] Use SWM Icons in `Menu` component (authored by jacek).
[web] Use SWM Icons in `Menu` component
Apr 1 2022, 3:51 AM
jacek closed D3385: [web] Introduce `Members` action in thread menu.
Apr 1 2022, 3:51 AM
jacek closed D3384: [web] Introduce `MembersModal`.
Apr 1 2022, 3:51 AM
jacek closed D3383: [web] Introduce `ThreadMembersList` component.
Apr 1 2022, 3:51 AM
jacek committed rCOMM7c0f9b452f9e: [web] Introduce `Members` action in thread menu (authored by jacek).
[web] Introduce `Members` action in thread menu
Apr 1 2022, 3:51 AM
jacek committed rCOMMff6060de2943: [web] Introduce `ThreadMembersList` component (authored by jacek).
[web] Introduce `ThreadMembersList` component
Apr 1 2022, 3:51 AM
jacek committed rCOMMbc98f9ff50f3: [web] Introduce `MembersModal` (authored by jacek).
[web] Introduce `MembersModal`
Apr 1 2022, 3:51 AM
jacek closed D3382: [web] Introduce member action callbacks in `ThreadMember` component.
Apr 1 2022, 3:51 AM
jacek closed D3380: [web] Introduce member action menu items in `ThreadMember` component.
Apr 1 2022, 3:51 AM
jacek closed D3381: [native, lib] Move thread members actions callbacks into shared lib function.
Apr 1 2022, 3:51 AM
jacek committed rCOMM60780083d920: [web] Introduce member action callbacks in `ThreadMember` component (authored by jacek).
[web] Introduce member action callbacks in `ThreadMember` component
Apr 1 2022, 3:51 AM
jacek committed rCOMM7f4f45ebd946: [web] Introduce member action menu items in `ThreadMember` component (authored by jacek).
[web] Introduce member action menu items in `ThreadMember` component
Apr 1 2022, 3:51 AM
jacek committed rCOMM811a9b45b539: [native, lib] Move thread members actions callbacks into shared lib function (authored by jacek).
[native, lib] Move thread members actions callbacks into shared lib function
Apr 1 2022, 3:51 AM
jacek closed D3379: [web] Introduce `ThreadMember` component.
Apr 1 2022, 3:51 AM
jacek committed rCOMM926ed5328b17: [web] Introduce `ThreadMember` component (authored by jacek).
[web] Introduce `ThreadMember` component
Apr 1 2022, 3:51 AM
jacek closed D3377: [web] use context to display `Menu` action items.
Apr 1 2022, 3:51 AM
jacek closed D3378: [web] Introduce `Label` component.
Apr 1 2022, 3:51 AM
jacek committed rCOMM4ad6a81bd401: [web] Introduce `Label` component (authored by jacek).
[web] Introduce `Label` component
Apr 1 2022, 3:51 AM
jacek committed rCOMMb8d86662dff2: [web] use context to display `Menu` action items (authored by jacek).
[web] use context to display `Menu` action items
Apr 1 2022, 3:51 AM
jacek closed D3376: [web] Introduce additional `Menu` styling variants.
Apr 1 2022, 3:51 AM
jacek committed rCOMM2ec3adefc49d: [web] Introduce additional `Menu` styling variants (authored by jacek).
[web] Introduce additional `Menu` styling variants
Apr 1 2022, 3:51 AM
jacek closed D3375: [web] Introduce menu context for displaying actions menu.
Apr 1 2022, 3:51 AM
jacek closed D3374: [web] Introduce common `Menu` component.
Apr 1 2022, 3:50 AM
jacek committed rCOMMedabcb272be9: [web] Introduce menu context for displaying actions menu (authored by jacek).
[web] Introduce menu context for displaying actions menu
Apr 1 2022, 3:50 AM
jacek committed rCOMM8d28c448c078: [web] Introduce common `Menu` component (authored by jacek).
[web] Introduce common `Menu` component
Apr 1 2022, 3:50 AM
jacek closed D3373: [web] Refactor `ChatTabs` to use `Tabs` component.
Apr 1 2022, 3:50 AM
jacek closed D3369: [web] Introduce common `Tabs` component.
Apr 1 2022, 3:50 AM
jacek committed rCOMMd4fd3c2eb045: [web] Introduce common `Tabs` component (authored by jacek).
[web] Introduce common `Tabs` component
Apr 1 2022, 3:50 AM
jacek committed rCOMMed8a73deeb7d: [web] Refactor `ChatTabs` to use `Tabs` component (authored by jacek).
[web] Refactor `ChatTabs` to use `Tabs` component
Apr 1 2022, 3:50 AM
jacek closed D3368: [web] Refactor search styling to match Figma.
Apr 1 2022, 3:50 AM
jacek closed D3367: [web] Introduce common `Search` component.
Apr 1 2022, 3:50 AM
jacek committed rCOMM9ac97ade83df: [web] Refactor search styling to match Figma (authored by jacek).
[web] Refactor search styling to match Figma
Apr 1 2022, 3:50 AM
jacek committed rCOMMed54b46da22e: [web] Introduce common `Search` component (authored by jacek).
[web] Introduce common `Search` component
Apr 1 2022, 3:50 AM
jacek closed D3459: [native] [fix] Disable promoting user to admin option if there is no admin role in the thread.
Apr 1 2022, 3:50 AM
jacek committed rCOMM088edd6467cf: [native] [fix] Disable promoting user to admin option if there is no admin role… (authored by jacek).
[native] [fix] Disable promoting user to admin option if there is no admin role…
Apr 1 2022, 3:50 AM
jacek updated the diff for D3373: [web] Refactor `ChatTabs` to use `Tabs` component.

rebase

Apr 1 2022, 2:45 AM
jacek updated the diff for D3377: [web] use context to display `Menu` action items.

removed redundant dependency and reused isOurMenuOpen where it was possible

Apr 1 2022, 2:33 AM

Mar 31 2022

jacek updated the diff for D3459: [native] [fix] Disable promoting user to admin option if there is no admin role in the thread.

rebase

Mar 31 2022, 2:35 AM
jacek updated the diff for D3490: [lib] Create common logic for filtering available thread members actions.

rebase

Mar 31 2022, 2:31 AM
jacek updated the diff for D3479: [web] Use SWM Icons in `Menu` component.

rebase

Mar 31 2022, 2:30 AM
jacek updated the diff for D3385: [web] Introduce `Members` action in thread menu.

rebase

Mar 31 2022, 2:30 AM
jacek updated the diff for D3384: [web] Introduce `MembersModal`.

rebase

Mar 31 2022, 2:30 AM
jacek updated the diff for D3383: [web] Introduce `ThreadMembersList` component.

rebase

Mar 31 2022, 2:29 AM
jacek updated the diff for D3382: [web] Introduce member action callbacks in `ThreadMember` component.

rebase

Mar 31 2022, 2:29 AM
jacek updated the diff for D3381: [native, lib] Move thread members actions callbacks into shared lib function.

rebase

Mar 31 2022, 2:28 AM
jacek updated the diff for D3380: [web] Introduce member action menu items in `ThreadMember` component.

rebase

Mar 31 2022, 2:28 AM
jacek updated the diff for D3379: [web] Introduce `ThreadMember` component.

rebase

Mar 31 2022, 2:28 AM
jacek updated the diff for D3378: [web] Introduce `Label` component.

rebase

Mar 31 2022, 2:27 AM
jacek updated the diff for D3377: [web] use context to display `Menu` action items.

remove useMemo & rebase

Mar 31 2022, 2:27 AM
jacek updated the diff for D3376: [web] Introduce additional `Menu` styling variants.

rebase

Mar 31 2022, 2:26 AM
jacek updated the diff for D3375: [web] Introduce menu context for displaying actions menu.

rebase

Mar 31 2022, 2:25 AM
jacek updated the diff for D3374: [web] Introduce common `Menu` component.

rebase

Mar 31 2022, 2:24 AM
jacek updated the diff for D3373: [web] Refactor `ChatTabs` to use `Tabs` component.

rebase

Mar 31 2022, 2:22 AM
jacek updated the diff for D3369: [web] Introduce common `Tabs` component.

rebase

Mar 31 2022, 2:21 AM
jacek updated the diff for D3368: [web] Refactor search styling to match Figma.

rebase

Mar 31 2022, 2:21 AM
jacek updated the diff for D3367: [web] Introduce common `Search` component.

rebase

Mar 31 2022, 2:21 AM
jacek updated the diff for D3459: [native] [fix] Disable promoting user to admin option if there is no admin role in the thread.

rebase

Mar 31 2022, 2:20 AM
jacek added inline comments to D3375: [web] Introduce menu context for displaying actions menu.
Mar 31 2022, 2:10 AM

Mar 30 2022

jacek updated the diff for D3490: [lib] Create common logic for filtering available thread members actions.

Rebase & fixes after review

Mar 30 2022, 7:48 AM
jacek requested review of D3375: [web] Introduce menu context for displaying actions menu.
Mar 30 2022, 7:23 AM
jacek updated the diff for D3377: [web] use context to display `Menu` action items.

Introduced changes from Ashoat suggested solution.
It seems more readable now

Mar 30 2022, 7:22 AM
jacek updated the diff for D3375: [web] Introduce menu context for displaying actions menu.

Include currentOpenMenu symbol in context, following the approach suggested in D3377

Mar 30 2022, 7:20 AM

Mar 28 2022

jacek added a comment to D3494: [web] Introduce search modal component.

Shouldn't we keep "one component per one file" approach? What is the convention in our project - when can/should we put some components together in one file?

Mar 28 2022, 7:20 AM
jacek updated the diff for D3377: [web] use context to display `Menu` action items.

simplify syntax, add early exit and move effect below updatePosition function following Ashoat's suggestions.

Mar 28 2022, 7:14 AM
jacek added inline comments to D3377: [web] use context to display `Menu` action items.
Mar 28 2022, 6:54 AM

Mar 25 2022

jacek updated the diff for D3384: [web] Introduce `MembersModal`.

fixed duplicated css property and simplified expression

Mar 25 2022, 9:11 AM
jacek updated the diff for D3384: [web] Introduce `MembersModal`.

Add missing newline

Mar 25 2022, 7:07 AM
jacek updated the diff for D3384: [web] Introduce `MembersModal`.

Use existing user search index

Mar 25 2022, 7:05 AM
jacek updated the diff for D3377: [web] use context to display `Menu` action items.

Changes in effects logic following Tomek's suggestions

Mar 25 2022, 7:00 AM
jacek updated the diff for D3368: [web] Refactor search styling to match Figma.

Fix padding

Mar 25 2022, 6:56 AM
jacek added 1 blocking reviewer(s) for D3368: [web] Refactor search styling to match Figma: tomek.
Mar 25 2022, 4:43 AM

Mar 22 2022

jacek requested review of D3490: [lib] Create common logic for filtering available thread members actions.
Mar 22 2022, 10:44 AM
jacek added inline comments to D3377: [web] use context to display `Menu` action items.
Mar 22 2022, 10:11 AM
jacek added inline comments to D3479: [web] Use SWM Icons in `Menu` component.
Mar 22 2022, 5:30 AM
jacek added inline comments to D3384: [web] Introduce `MembersModal`.
Mar 22 2022, 5:29 AM
jacek requested review of D3375: [web] Introduce menu context for displaying actions menu.
Mar 22 2022, 5:18 AM
jacek updated the diff for D3479: [web] Use SWM Icons in `Menu` component.

removed redundant css class

Mar 22 2022, 5:18 AM
jacek retitled D3375: [web] Introduce menu context for displaying actions menu from [web] Introduce portal for displaying actions menu to [web] Introduce menu context for displaying actions menu.
Mar 22 2022, 5:16 AM
jacek updated the diff for D3377: [web] use context to display `Menu` action items.

Simplified logic by removing isOpen state.

Mar 22 2022, 5:14 AM