Page MenuHomePhabricator
Feed Advanced Search

May 16 2022

abosh updated the diff for D3980: [web] Fix `ThreadSettingsGeneralTab` save button `disabled` prop.

Handled issue in onChangeColor, per feedback.

May 16 2022, 4:30 PM
abosh accepted D4042: [web] Memoize `NotificationsOption` `onSelect` prop w/ `useCallback` hook.
May 16 2022, 8:12 AM

May 12 2022

abosh closed D3939: [native] Make `ColorSelector` fully functional.
May 12 2022, 5:36 PM
abosh committed rCOMMb18185e5a9d7: [native] Make `ColorSelector` fully functional (authored by abosh).
[native] Make `ColorSelector` fully functional
May 12 2022, 5:36 PM

May 11 2022

abosh updated the diff for D3939: [native] Make `ColorSelector` fully functional.

Address inline feedback

May 11 2022, 9:42 AM

May 9 2022

abosh updated the diff for D3980: [web] Fix `ThreadSettingsGeneralTab` save button `disabled` prop.

Removed case when queuedChanges.name and queuedChanges.description are '' (if the
user wants to clear the name/description, this is stil a change!).

May 9 2022, 10:09 PM
abosh added inline comments to D3980: [web] Fix `ThreadSettingsGeneralTab` save button `disabled` prop.
May 9 2022, 10:07 PM
abosh added inline comments to D3980: [web] Fix `ThreadSettingsGeneralTab` save button `disabled` prop.
May 9 2022, 10:01 PM
abosh requested review of D3980: [web] Fix `ThreadSettingsGeneralTab` save button `disabled` prop.
May 9 2022, 9:57 PM

May 6 2022

abosh added inline comments to D3939: [native] Make `ColorSelector` fully functional.
May 6 2022, 8:49 AM
abosh updated the summary of D3939: [native] Make `ColorSelector` fully functional.
May 6 2022, 8:47 AM
abosh added inline comments to D3939: [native] Make `ColorSelector` fully functional.
May 6 2022, 12:34 AM
abosh requested review of D3939: [native] Make `ColorSelector` fully functional.
May 6 2022, 12:33 AM

May 5 2022

abosh closed D3916: [web] Match `ChatInputBar` icon colors with thread color.
May 5 2022, 11:35 AM
abosh committed rCOMMf9d68295ecef: [web] Match `ChatInputBar` icon colors with thread color (authored by abosh).
[web] Match `ChatInputBar` icon colors with thread color
May 5 2022, 11:35 AM
abosh closed D3868: [native] Add active state to `ColorSelector`.
May 5 2022, 11:32 AM
abosh committed rCOMM025e2fdf12b3: [native] Add active state to `ColorSelector` (authored by abosh).
[native] Add active state to `ColorSelector`
May 5 2022, 11:32 AM
abosh updated the diff for D3868: [native] Add active state to `ColorSelector`.

rebase before landing

May 5 2022, 11:31 AM
abosh added inline comments to D3916: [web] Match `ChatInputBar` icon colors with thread color.
May 5 2022, 11:25 AM

May 4 2022

abosh updated the diff for D3868: [native] Add active state to `ColorSelector`.

Address feedback about outerRingStyle -- created new Stylesheet style for selected outerRing.

May 4 2022, 5:06 PM
abosh closed D3917: [web] Fix `See more...` button alignment regression.
May 4 2022, 4:53 PM
abosh committed rCOMM6497c6952071: [web] Fix `See more...` button alignment regression (authored by abosh).
[web] Fix `See more...` button alignment regression
May 4 2022, 4:53 PM
abosh closed D3846: [native] Increase contrast between `ColorPickerModal` and background view.
May 4 2022, 4:47 PM
abosh committed rCOMM4f08459ae2cf: [native] Increase contrast between `ColorPickerModal` and background view (authored by abosh).
[native] Increase contrast between `ColorPickerModal` and background view
May 4 2022, 4:47 PM
abosh requested review of D3917: [web] Fix `See more...` button alignment regression.
May 4 2022, 11:20 AM
abosh added inline comments to D3916: [web] Match `ChatInputBar` icon colors with thread color.
May 4 2022, 11:06 AM
abosh requested review of D3916: [web] Match `ChatInputBar` icon colors with thread color.
May 4 2022, 11:03 AM

May 3 2022

abosh updated the diff for D3846: [native] Increase contrast between `ColorPickerModal` and background view.

Removed glow and kept light outline.

image.png (1×1 px, 479 KB)

May 3 2022, 7:32 PM
abosh updated the diff for D3868: [native] Add active state to `ColorSelector`.

Added translucent outer ring and removed checkmark to match web design.

May 3 2022, 7:29 PM

May 2 2022

abosh closed D3886: [landing] Add thumbnail and description for landing page when shared.
May 2 2022, 10:56 AM
abosh committed rCOMM36d9c7660b67: [landing] Add thumbnail and description for landing page when shared (authored by abosh).
[landing] Add thumbnail and description for landing page when shared
May 2 2022, 10:56 AM
abosh updated the diff for D3868: [native] Add active state to `ColorSelector`.

Addressed inline feedback and updated styles by removing glow. For now, it's basically mimicking the styles on web (see attached image) except the styles on web use a hover property which can't really be done on native. Instead, the checkmark is what indicates to the user what the current color is. Didn't seem to find a Figma design for native, so that might have to be updated or decided upon.

May 2 2022, 8:21 AM
abosh added a comment to D3886: [landing] Add thumbnail and description for landing page when shared.

yeah, you're right. I saw it in the Linear issue and wanted to add it to bridge the contexts between the two issues, since we need to add a staging environment with a deploy preview to test this diff. Just edited the Test Plan to accurately describe what in this issue is related to Sandcastle.

May 2 2022, 8:09 AM
abosh updated the summary of D3886: [landing] Add thumbnail and description for landing page when shared.
May 2 2022, 8:08 AM
abosh requested review of D3886: [landing] Add thumbnail and description for landing page when shared.
May 2 2022, 7:45 AM

Apr 29 2022

abosh added a comment to D3846: [native] Increase contrast between `ColorPickerModal` and background view.

Are you guys talking about the horizontal lines in the red circles? Pretty sure those are just the strokes at the top/bottom of each thread settings "section" in the view behind the modal?

Apr 29 2022, 8:02 PM
abosh closed D3866: [docs] Fix `nvm` setup instructions.
Apr 29 2022, 2:54 PM
abosh committed rCOMM0c97665eb85a: [docs] Fix `nvm` setup instructions (authored by abosh).
[docs] Fix `nvm` setup instructions
Apr 29 2022, 2:54 PM

Apr 27 2022

abosh updated the diff for D3866: [docs] Fix `nvm` setup instructions.

Address feedback about Apple Silicon/Intel Mac wording. Looked through the docs and saw that the S in Apple silicon was lowercase (as it should be) and Intel is referred to as Intel x86-64. The term "Apple silicon Macs" is only referred to in the Python 2 section, but not paired with "Intel x86-64 Macs," so this has been revised. Also replaced all single quote characters with apostrophes.

Apr 27 2022, 7:36 PM
abosh added inline comments to D3868: [native] Add active state to `ColorSelector`.
Apr 27 2022, 7:18 PM
abosh requested review of D3868: [native] Add active state to `ColorSelector`.
Apr 27 2022, 7:14 PM
abosh updated the diff for D3866: [docs] Fix `nvm` setup instructions.

Removed extraneous colon (was in Markdown editor, just forgot to include it in VS Code in last commit)

Apr 27 2022, 6:55 PM
abosh updated the diff for D3866: [docs] Fix `nvm` setup instructions.

Address feedback about inaccurate claim with what Homebrew prints and order of narrative. Also replaced . with \. as per inline comment.

Apr 27 2022, 6:54 PM
abosh updated the summary of D3866: [docs] Fix `nvm` setup instructions.
Apr 27 2022, 4:39 PM
abosh added inline comments to D3866: [docs] Fix `nvm` setup instructions.
Apr 27 2022, 4:37 PM
abosh requested review of D3866: [docs] Fix `nvm` setup instructions.
Apr 27 2022, 4:33 PM

Apr 25 2022

abosh closed D3798: [native] Introduce `ColorSelector` component.
Apr 25 2022, 11:22 PM
abosh committed rCOMMf3d2d082e893: [native] Introduce `ColorSelector` component (authored by abosh).
[native] Introduce `ColorSelector` component
Apr 25 2022, 11:22 PM
abosh updated the summary of D3846: [native] Increase contrast between `ColorPickerModal` and background view.
Apr 25 2022, 6:29 PM
abosh requested review of D3846: [native] Increase contrast between `ColorPickerModal` and background view.
Apr 25 2022, 6:26 PM

Apr 24 2022

abosh updated the diff for D3798: [native] Introduce `ColorSelector` component.

fix git issues

Apr 24 2022, 3:36 PM
abosh closed D3790: [native] Introduce `ColorSelectorButton` component.
Apr 24 2022, 3:24 PM
abosh committed rCOMMc093db50dc3b: [native] Introduce `ColorSelectorButton` component (authored by abosh).
[native] Introduce `ColorSelectorButton` component
Apr 24 2022, 3:24 PM

Apr 21 2022

abosh requested review of D3798: [native] Introduce `ColorSelector` component.
Apr 21 2022, 10:08 AM

Apr 20 2022

abosh updated the diff for D3790: [native] Introduce `ColorSelectorButton` component.

Updated memoization to memoize array passed into style prop for the View in ColorSelectorButton.

Apr 20 2022, 7:51 PM
abosh updated the diff for D3790: [native] Introduce `ColorSelectorButton` component.
Apr 20 2022, 7:50 PM
abosh updated the diff for D3790: [native] Introduce `ColorSelectorButton` component.

Memoized the backgroundColor style attribute for ColorSelectorButton.

Apr 20 2022, 5:24 PM
abosh retitled D3790: [native] Introduce `ColorSelectorButton` component from [native] Introduce `ColorSelector` component to [native] Introduce `ColorSelectorButton` component.
Apr 20 2022, 4:50 PM
abosh updated the diff for D3790: [native] Introduce `ColorSelectorButton` component.

Modify this diff to only include ColorSelectorButton.

Apr 20 2022, 4:49 PM
abosh updated the summary of D3790: [native] Introduce `ColorSelectorButton` component.
Apr 20 2022, 10:39 AM
abosh retitled D3790: [native] Introduce `ColorSelectorButton` component from [native] Redesign `native` `ColorPicker` component to [native] Introduce `ColorSelector` component.
Apr 20 2022, 10:35 AM
abosh requested review of D3790: [native] Introduce `ColorSelectorButton` component.
Apr 20 2022, 10:32 AM

Apr 19 2022

abosh added inline comments to D3765: [web] Move `onChangeName` up from `ThreadSettingsModal` to `ConnectedThreadSettingsModal`.
Apr 19 2022, 9:52 AM

Apr 13 2022

abosh closed D3541: [web] Fix "See more..." button alignment in `ChatThreadListSeeMoreSidebars` component.
Apr 13 2022, 2:29 PM
abosh committed rCOMM7f0a10aedab9: [web] Fix "See more..." button alignment in `ChatThreadListSeeMoreSidebars`… (authored by abosh).
[web] Fix "See more..." button alignment in `ChatThreadListSeeMoreSidebars`…
Apr 13 2022, 2:28 PM

Apr 12 2022

abosh updated the diff for D3541: [web] Fix "See more..." button alignment in `ChatThreadListSeeMoreSidebars` component.

Updated "See more..." button alignment to match @benschac's changes

Apr 12 2022, 11:04 AM

Apr 11 2022

abosh closed D3604: [web] Link wordmark in header to app "homepage".
Apr 11 2022, 11:48 AM
abosh committed rCOMM29e11a01bd2c: [web] Link wordmark in header to app "homepage" (authored by abosh).
[web] Link wordmark in header to app "homepage"
Apr 11 2022, 11:48 AM

Apr 8 2022

abosh updated the diff for D3604: [web] Link wordmark in header to app "homepage".

Removed div.main-header CSS from selector on <a> tag. Also added aria-label: Go to Comm Home to wordmark. Screenreader now reads "Go to Comm Home" when clicking on wordmark.

Apr 8 2022, 1:07 PM

Apr 7 2022

abosh updated the diff for D3604: [web] Link wordmark in header to app "homepage".

Updated h1 tag by wrapping Comm text in an anchor, per @benschac's suggestion. Also allows for a title attribute on the a when hovering, which increases accessibility.

Apr 7 2022, 8:45 AM

Apr 6 2022

abosh updated the diff for D3604: [web] Link wordmark in header to app "homepage".

Moved CSS into already existing div.main-header > h1 selector. Will defer to your guys' input on adding the .wordmark class because there was already a CSS selector/CSS styles that were in the h1 selector, although I think it's clearer if we rename the selector to use a class instead of h1.

Apr 6 2022, 2:52 PM
abosh added 1 blocking reviewer(s) for D3604: [web] Link wordmark in header to app "homepage": atul.
Apr 6 2022, 11:09 AM
abosh updated the diff for D3604: [web] Link wordmark in header to app "homepage".

Clicking on the wordmark takes the user to the main Chat tab without refreshing the page. The <a> tag has been removed and instead the <h1> tag uses an onClick event handler to update the navigation info.

Apr 6 2022, 11:06 AM
abosh closed D3605: [web] Added `LoadingIndicator` to `LoginForm` "Log in" button.
Apr 6 2022, 10:17 AM
abosh committed rCOMMe58dcfdca205: [web] Added `LoadingIndicator` to `LoginForm` "Log in" button (authored by abosh).
[web] Added `LoadingIndicator` to `LoginForm` "Log in" button
Apr 6 2022, 10:17 AM
abosh closed D3606: [web] Removed extraneous `.loading-indicator-loading` CSS selector.
Apr 6 2022, 10:17 AM
abosh committed rCOMMa3532d10d1c3: [web] Removed extraneous `.loading-indicator-loading` CSS selector (authored by abosh).
[web] Removed extraneous `.loading-indicator-loading` CSS selector
Apr 6 2022, 10:17 AM
abosh accepted D3621: [docs] Fix `generate-olm-config.js` script in `dev_environment` docs.

Yup, it should be yarn script dist/scripts/generate-olm-config.js because the JSON file does not exist, and it looks like that was the change that was made!

Apr 6 2022, 9:18 AM

Apr 5 2022

abosh added inline comments to D3618: [web] [feat] [ENG-972] update modal header to match design.
Apr 5 2022, 8:53 AM
abosh added inline comments to D3539: [web] [feat] [ENG-766] toggle longer arrow for multiple thread sidebars in chat thread list.
Apr 5 2022, 8:48 AM

Apr 4 2022

abosh updated the diff for D3605: [web] Added `LoadingIndicator` to `LoginForm` "Log in" button.

Removed function and used conditional rendering outside of JSX, per https://beta.reactjs.org/learn#conditional-rendering

Apr 4 2022, 2:29 PM

Apr 3 2022

abosh planned changes to D3605: [web] Added `LoadingIndicator` to `LoginForm` "Log in" button.
Apr 3 2022, 11:50 PM
abosh updated the diff for D3605: [web] Added `LoadingIndicator` to `LoginForm` "Log in" button.

Removed ternary condition that returned JSX element and used function instead.

Apr 3 2022, 4:03 PM

Apr 1 2022

abosh added 1 blocking reviewer(s) for D3605: [web] Added `LoadingIndicator` to `LoginForm` "Log in" button: atul.
Apr 1 2022, 8:29 PM
abosh added 1 blocking reviewer(s) for D3606: [web] Removed extraneous `.loading-indicator-loading` CSS selector: atul.
Apr 1 2022, 8:27 PM
abosh added inline comments to D3604: [web] Link wordmark in header to app "homepage".
Apr 1 2022, 5:58 PM
abosh added inline comments to D3606: [web] Removed extraneous `.loading-indicator-loading` CSS selector.
Apr 1 2022, 5:57 PM
abosh updated the test plan for D3605: [web] Added `LoadingIndicator` to `LoginForm` "Log in" button.
Apr 1 2022, 5:55 PM
abosh updated the summary of D3605: [web] Added `LoadingIndicator` to `LoginForm` "Log in" button.
Apr 1 2022, 5:55 PM
abosh updated the summary of D3604: [web] Link wordmark in header to app "homepage".
Apr 1 2022, 5:53 PM
abosh updated the summary of D3604: [web] Link wordmark in header to app "homepage".
Apr 1 2022, 5:52 PM
abosh updated the summary of D3604: [web] Link wordmark in header to app "homepage".
Apr 1 2022, 5:51 PM
abosh requested review of D3606: [web] Removed extraneous `.loading-indicator-loading` CSS selector.
Apr 1 2022, 5:34 PM
abosh requested review of D3605: [web] Added `LoadingIndicator` to `LoginForm` "Log in" button.
Apr 1 2022, 5:27 PM
abosh requested review of D3604: [web] Link wordmark in header to app "homepage".
Apr 1 2022, 5:17 PM
abosh planned changes to D3541: [web] Fix "See more..." button alignment in `ChatThreadListSeeMoreSidebars` component.
Apr 1 2022, 4:56 PM
abosh updated the diff for D3541: [web] Fix "See more..." button alignment in `ChatThreadListSeeMoreSidebars` component.

Rebase and made necessary changes to keep things aligned (had to increase padding-left to 66px):

Screen Shot 2022-04-01 at 4.53.33 PM.png (582×950 px, 33 KB)

Apr 1 2022, 4:55 PM
abosh closed D3542: [web] Refactor `classNames` in `threadRow` to take object instead of array.
Apr 1 2022, 4:46 PM
abosh committed rCOMM5756589cec12: [web] Refactor `classNames` in `threadRow` to take object instead of array (authored by abosh).
[web] Refactor `classNames` in `threadRow` to take object instead of array
Apr 1 2022, 4:46 PM
abosh updated the diff for D3542: [web] Refactor `classNames` in `threadRow` to take object instead of array.

Rebase before landing

Apr 1 2022, 4:44 PM