Page MenuHomePhabricator
Feed Advanced Search

Sep 15 2022

abosh updated the diff for D5040: [lib] Use slanted apostrophes and quotation marks in `change-settings-message-spec`.

Addressed @tomek's feedback:

Sep 15 2022, 4:07 PM

Sep 14 2022

abosh removed a reviewer for D5040: [lib] Use slanted apostrophes and quotation marks in `change-settings-message-spec`: jon.
Sep 14 2022, 4:25 PM
abosh retitled D5040: [lib] Use slanted apostrophes and quotation marks in `change-settings-message-spec` from [lib] Use apostrophe and quotation marks in `change-settings-message-spec` to [lib] Use slanted apostrophes and quotation marks in `change-settings-message-spec`.
Sep 14 2022, 4:25 PM

Sep 12 2022

abosh accepted D5111: [web] Add box shadow to message tooltips.

D4343, but looks good otherwise!

Sep 12 2022, 11:20 AM

Sep 2 2022

abosh added a comment to D5048: [native] Implement darker color tint to block quote container.

Cool, I can see them now! But your revision is still in a Needs Revision state. That means it's been removed from reviewers' queues on the Phabricator home screen (under Ready to Review). If you want reviewers to see this diff, you should submit the Request Review action (same place as Abandon Revision). Every time you update a diff or want reviewers to take a look at it again, submit this action. If you want to remove a diff from reviewers' queues because you plan to make changes, submit the Plan Changes action.

Sep 2 2022, 11:52 PM
abosh attached a referenced file: F158119: image.png.
Sep 2 2022, 11:42 PM
abosh requested changes to D5048: [native] Implement darker color tint to block quote container.

Hey Ginsu, looks like your files weren't attached.

image.png (520×1 px, 59 KB)

Sep 2 2022, 11:41 PM
abosh added a comment to D5047: removed unnecessary console logs [DISREGARD].

Instead of writing [DISREGARD], you can submit the Abandon Revision action!

image.png (654×2 px, 171 KB)

Sep 2 2022, 11:40 PM
abosh updated the summary of D5040: [lib] Use slanted apostrophes and quotation marks in `change-settings-message-spec`.
Sep 2 2022, 6:06 PM
abosh updated the diff for D5040: [lib] Use slanted apostrophes and quotation marks in `change-settings-message-spec`.

Added apostrophe I missed

Sep 2 2022, 12:42 PM
abosh requested review of D5040: [lib] Use slanted apostrophes and quotation marks in `change-settings-message-spec`.
Sep 2 2022, 12:33 PM
abosh requested review of D5032: [native] Select thread name when clicking `EditSettingButton`.
Sep 2 2022, 12:08 AM

Sep 1 2022

abosh closed D5000: [web] Group usernames case insensitively in `MembersList`.
Sep 1 2022, 6:11 PM
abosh committed rCOMMd3e08bf50142: [web] Group usernames case insensitively in `MembersList` (authored by abosh).
[web] Group usernames case insensitively in `MembersList`
Sep 1 2022, 6:11 PM
abosh closed D4931: [web] Disable Save button after settings are saved in `ThreadSettingsGeneralTab`.
Sep 1 2022, 1:49 AM
abosh committed rCOMMa9eb8f8651d6: [web] Disable Save button after settings are saved in `ThreadSettingsGeneralTab` (authored by abosh).
[web] Disable Save button after settings are saved in `ThreadSettingsGeneralTab`
Sep 1 2022, 1:49 AM
abosh added a comment to D4931: [web] Disable Save button after settings are saved in `ThreadSettingsGeneralTab`.

Going to land this and address @tomek's question in a Linear issue for a (potential) separate diff. For now, I think clearing the queued actions in all cases is a valid way forward.

Sep 1 2022, 1:46 AM
abosh requested review of D5000: [web] Group usernames case insensitively in `MembersList`.
Sep 1 2022, 1:45 AM

Aug 31 2022

abosh added a comment to D4999: [web] Implement darker thread color tint to blockquote container.

Had this tab open for 2 hours, didn't realize @atul got a chance to look at this before me. Just submitted my feedback.

Aug 31 2022, 11:26 PM
abosh requested changes to D4999: [web] Implement darker thread color tint to blockquote container.

Hey @ginsu, your first diff, woohoo!

Aug 31 2022, 11:25 PM
abosh updated the summary of D4999: [web] Implement darker thread color tint to blockquote container.
Aug 31 2022, 9:45 PM
abosh closed D4898: [keyserver] Add `uploadResult` to `uploadRows` object in `createUploads`.
Aug 31 2022, 10:42 AM
abosh committed rCOMMb6f555611b4c: [keyserver] Add `uploadResult` to `uploadRows` object in `createUploads` (authored by abosh).
[keyserver] Add `uploadResult` to `uploadRows` object in `createUploads`
Aug 31 2022, 10:42 AM
abosh accepted D4990: [lib] Introduce `tMediaMessage[Photo/Video/Media]` to validate requests to `textMessageCreationResponder`.

Read up on tcomb since I had never heard of it before, but still sort of unsure why we need these. Is it because tcomb checks types at runtime and Flow is static? This diff makes sense according to the documentation of tcomb, however, and matches the spec'd design laid out in D4982's diff summary.

Aug 31 2022, 10:00 AM
abosh added inline comments to D4985: [lib] Introduce `MediaMessageServerDBContent` type.
Aug 31 2022, 9:39 AM
abosh added inline comments to D4979: [native] Upload video thumbnails to `keyserver` and persist in serverDB.
Aug 31 2022, 9:36 AM
abosh accepted D4991: [lib] Introduce tests for `tMediaMessage[Photo/Video/Media]`.
Aug 31 2022, 9:35 AM

Aug 30 2022

abosh updated the summary of D4991: [lib] Introduce tests for `tMediaMessage[Photo/Video/Media]`.
Aug 30 2022, 10:13 PM
abosh added a comment to D4985: [lib] Introduce `MediaMessageServerDBContent` type.

Also maybe you should show an example of the case when there are both images and videos in the same message, instead of just one video in the diff summary.

Aug 30 2022, 2:01 PM
abosh added 1 blocking reviewer(s) for D4985: [lib] Introduce `MediaMessageServerDBContent` type: tomek.
Aug 30 2022, 2:00 PM
abosh accepted D4985: [lib] Introduce `MediaMessageServerDBContent` type.

In the future, I'd also move to include a media table (discussed this with @atul offline) but for now this approach should work, and won't involve having to migrate queries, just modifying them to parse the new content column.

Aug 30 2022, 2:00 PM
abosh added a reviewer for D4898: [keyserver] Add `uploadResult` to `uploadRows` object in `createUploads`: tomek.
Aug 30 2022, 1:02 PM
abosh accepted D4980: [native] Update local video messages with realized `thumbnailURI` upon successful upload.

Yeah, the main thing that is confusing is uploadResult and uploadThumbnailResult (if video) being falsey after the try / catch block. Like as a reader this feels complicated. To me, I think the upload failing be handled in one section before moving onto the rest of the code where we can assume the uploads were successful, and we no longer have to introduce truthy checks. Obviously we may still need checks later on, but if we broke a lot of things into methods we could let this be handled outside of this huge function.

Aug 30 2022, 1:00 PM
abosh added a comment to D4982: [keyserver] Introduce `legacyMultimediaMessageCreationResponder`.
In D4982#144870, @atul wrote:

Personally prefer the legacyMultimediaMessageCreationResponder naming. I think it makes it clear that it's around to support old clients and it kind of "deprecated" and that multimediaMessageCreationResponder(...) is what will handle things going forward.

Even image messages (IMAGES: 14) will go through the new responder once implemented.

Aug 30 2022, 12:54 PM
abosh accepted D4984: [keyserver] Add `--source-maps` flag to `babel-build` for more sane debugging experience.

Patched this and tried it. Wow this should have been done long ago. Makes debugging keyserver so much easier

Aug 30 2022, 12:15 PM
abosh accepted D4979: [native] Upload video thumbnails to `keyserver` and persist in serverDB.
Aug 30 2022, 10:35 AM
abosh requested changes to D4979: [native] Upload video thumbnails to `keyserver` and persist in serverDB.
Aug 30 2022, 9:37 AM
abosh updated the diff for D4931: [web] Disable Save button after settings are saved in `ThreadSettingsGeneralTab`.

The current approach clears the changes when an error is detected, so we make it impossible to just retry. Maybe we should revisit it?

Aug 30 2022, 9:20 AM

Aug 29 2022

abosh accepted D4982: [keyserver] Introduce `legacyMultimediaMessageCreationResponder`.

So I assume steps 2-8 will be separate diffs in this stack.

Aug 29 2022, 11:03 PM
abosh accepted D4981: [native] Rename `promises` to `cleanupPromises` at end of uploadFile(...).

Yup, this makes sense!

Aug 29 2022, 10:43 PM
abosh requested changes to D4980: [native] Update local video messages with realized `thumbnailURI` upon successful upload.

I'm a bit confused on what it means if uploadResult (or uploadThumbnailResult) fails. Is it just to push a failed 'upload' step to steps? @ashoat sort of mentioned this in D932, although he was referring to uploadThumbnailResult only.

Aug 29 2022, 10:43 PM
abosh added a comment to D4979: [native] Upload video thumbnails to `keyserver` and persist in serverDB.

We can just create a variable for it outside where uploadResult is declared, then it's clearer to me what each step means since we explicitly set the inner if statement's result to uploadThumbnailResult

Aug 29 2022, 10:20 PM
abosh attached a referenced file: F153078: image.png.
Aug 29 2022, 10:17 PM
abosh attached a referenced file: F153073: image.png.
Aug 29 2022, 10:17 PM
abosh attached a referenced file: F153066: image.png.
Aug 29 2022, 10:17 PM
abosh requested changes to D4979: [native] Upload video thumbnails to `keyserver` and persist in serverDB.

Thanks for the NOTE, that helped me understand why this change can be landed as-is! Looks like the SQL query in upload-deleters will catch all these NULL-assigned containers. Some inline suggestions and questions.

Aug 29 2022, 10:16 PM
abosh added inline comments to D4968: [Docs] Update supported workflow information.
Aug 29 2022, 2:30 PM
abosh requested changes to D4968: [Docs] Update supported workflow information.
Aug 29 2022, 2:29 PM
abosh added inline comments to D4968: [Docs] Update supported workflow information.
Aug 29 2022, 11:24 AM
abosh requested changes to D4968: [Docs] Update supported workflow information.

Requesting changes for the inline edits, the footnote discussion can be a Linear issue or separate diff or something. Also curious for @ashoat's thoughts when he gets back, if he decides the footnotes are fine then it's ok. So maybe a Linear issue should be created, he should be subscribed, so when he sees it there he can respond!

Aug 29 2022, 11:23 AM
abosh accepted D4969: [Docs] Fix nix store typo.
Aug 29 2022, 11:15 AM
abosh accepted D4978: [Docs] Update nix_dev_env.md to reference relevant docs.
Aug 29 2022, 11:14 AM
abosh accepted D4925: [web] Use safer type declarations instead of invariants.
Aug 29 2022, 11:08 AM
abosh accepted D4967: [Docs] Organize comprehensive nix documentation.

Thanks for updating this diff! Accepting, assuming that this code is copied and pasted from dev_environment.md outside of the "Nix" headers.

Aug 29 2022, 11:01 AM
abosh requested changes to D4970: [Docs] Provide nixified version of tableplus.

almost done!

Aug 29 2022, 10:39 AM
abosh closed D4961: [native] Use `values(...)` in `InputStateContainer`.
Aug 29 2022, 10:17 AM
abosh committed rCOMM08dfbbfd79e7: [native] Use `values(...)` in `InputStateContainer` (authored by abosh).
[native] Use `values(...)` in `InputStateContainer`
Aug 29 2022, 10:17 AM

Aug 27 2022

abosh requested changes to D4967: [Docs] Organize comprehensive nix documentation.

Only the content of nix_dev_env.md changed significantly. The content of the nix_*_{setup,workflows}.md are copy and pasted from the the existing dev_environment.md with exception of initial headers.

Aug 27 2022, 11:13 AM
abosh accepted D4971: Revert "[landing] SIWE component with RainbowKit that connects & signs a message".

Awesome! Can probably land this since all the builds passed.

Aug 27 2022, 11:02 AM
abosh requested changes to D4971: Revert "[landing] SIWE component with RainbowKit that connects & signs a message".

Looks like the Android CI is failing here. Please don't request review (manually, by submitting an action) if the CI is failing unless you have a good reason. I've restarted the Android CI build to see if it passes again, but Phabricator automatically adds a "Changes Planned" action to your diff if any builds fail. When you request review manually, the Changes Planned tag gets overwritten by the Needs Review tag. But this isn't great, because if the CI is failing, your code can't be landed as-is (unless there's a good reason). So any review is probably unnecessary if the builds fail. Changes Planned removes the diff from reviewers' queues until the CI can pass again.

Aug 27 2022, 10:59 AM
abosh accepted D4965: [Nix] Set PATH for android utilities.
Aug 27 2022, 12:50 AM
abosh requested changes to D4970: [Docs] Provide nixified version of tableplus.
Aug 27 2022, 12:44 AM

Aug 26 2022

abosh requested changes to D4964: [landing] revert changes in D4510.

Hmm...your before and after pics are mine. I didn't test this diff. Additionally, the after pic is just the current state of https://comm.app/, our public facing landing page. This diff broke in dev, not prod.

Aug 26 2022, 3:15 PM
abosh updated the diff for D4898: [keyserver] Add `uploadResult` to `uploadRows` object in `createUploads`.

Remove object values for keys with same name

Aug 26 2022, 1:52 PM
abosh requested review of D4961: [native] Use `values(...)` in `InputStateContainer`.
Aug 26 2022, 1:51 PM
abosh removed 1 blocking reviewer(s) for D4404: [docs] updated dev env docs for protobuf edge case: varun.
Aug 26 2022, 1:26 PM
abosh retitled D4404: [docs] updated dev env docs for protobuf edge case from Summary: updated dev env docs for protobuf edge case to [docs] updated dev env docs for protobuf edge case.
Aug 26 2022, 1:26 PM
abosh accepted D4958: [lib, web, native] extract getting the keyserver admin.
Aug 26 2022, 12:49 PM
abosh removed 1 blocking reviewer(s) for D4956: [web] Unify redux action types variables: atul.
Aug 26 2022, 12:48 PM
abosh updated the diff for D4931: [web] Disable Save button after settings are saved in `ThreadSettingsGeneralTab`.

Use async / await instead of .then(...)

Aug 26 2022, 12:40 PM
abosh closed D4955: [native] Make return value more concise in `uploadInProgress`.
Aug 26 2022, 12:30 PM
abosh committed rCOMMc3c3ab6a16f7: [native] Make return value more concise in `uploadInProgress` (authored by abosh).
[native] Make return value more concise in `uploadInProgress`
Aug 26 2022, 12:29 PM
abosh closed D4890: [native] Make `failed` `boolean` in `PendingMultimediaUpload`.
Aug 26 2022, 12:29 PM
abosh closed D4891: [web] Make `failed` `boolean` in `PendingMultimediaUpload`.
Aug 26 2022, 12:29 PM
abosh committed rCOMM73e1804de16e: [native] Make `failed` `boolean` in `PendingMultimediaUpload` (authored by abosh).
[native] Make `failed` `boolean` in `PendingMultimediaUpload`
Aug 26 2022, 12:29 PM
abosh committed rCOMM27b9b60c69cc: [web] Make `failed` `boolean` in `PendingMultimediaUpload` (authored by abosh).
[web] Make `failed` `boolean` in `PendingMultimediaUpload`
Aug 26 2022, 12:29 PM
abosh closed D4892: [native] Use `Array.some(...)` in `uploadInProgress`.
Aug 26 2022, 12:29 PM
abosh committed rCOMM7f7f5ebfdd11: [native] Use `Array.some(...)` in `uploadInProgress` (authored by abosh).
[native] Use `Array.some(...)` in `uploadInProgress`
Aug 26 2022, 12:29 PM
abosh added 2 blocking reviewer(s) for D4404: [docs] updated dev env docs for protobuf edge case: ashoat, varun.

Don't know if @ashoat will be able to review anytime soon, but him or Varun should take a look at it. I think you can remove one or the other as blocking once they do, since @ashoat already looked at this diff and you seem to have incorporated his feedback.

Aug 26 2022, 11:08 AM
abosh accepted D4404: [docs] updated dev env docs for protobuf edge case.
Aug 26 2022, 11:07 AM
abosh added a comment to D4931: [web] Disable Save button after settings are saved in `ThreadSettingsGeneralTab`.
In D4931#143877, @abosh wrote:

Yeah, I wasn't entirely sure what to do in that case. The reason I threw away the changes is because of line 113, where we do the same thing if changeThreadSettingsAction fails. So I figured if we do it when it fails, and we want to do it when it passes as well (since now we want the button to be disabled), it would be ok. I've updated the diff to use .then(...) so we only clear queuedChanges if the promise is resolved.

Not sure if this is necessary though, since on line 113 we also clear queuedChanges if an error occurs when changing the thread settings, but now the .then(...) ensures it only happens on success of dispatchActionPromise, too, not just changeThreadSettingsAction.

Aug 26 2022, 10:55 AM
abosh accepted D4956: [web] Unify redux action types variables.

At a high level looks good, but why was updateNavInfoActionType in nav-types to begin with? Is there a difference between a nav type and action type? Or should we keep all "actionable" types together (anything with 'update', 'set', etc.), like in this diff?

Aug 26 2022, 10:48 AM
abosh updated the diff for D4931: [web] Disable Save button after settings are saved in `ThreadSettingsGeneralTab`.
Aug 26 2022, 10:38 AM
abosh closed D4932: [web] Simplify `return` value of `changeThreadSettingsAction`.
Aug 26 2022, 10:28 AM
abosh committed rCOMM669f84ba59ec: [web] Simplify `return` value of `changeThreadSettingsAction` (authored by abosh).
[web] Simplify `return` value of `changeThreadSettingsAction`
Aug 26 2022, 10:28 AM
abosh closed D4930: [web] Memoize `loginButtonContent` and `saveButtonContent`.
Aug 26 2022, 10:27 AM
abosh committed rCOMM24746e00189d: [web] Memoize `loginButtonContent` and `saveButtonContent` (authored by abosh).
[web] Memoize `loginButtonContent` and `saveButtonContent`
Aug 26 2022, 10:27 AM
abosh resigned from D4959: [native] added react-native-webview to support SIWE.

Resigning since I don't have much context on adding new dependencies. But nice adding @ashoat here as a first-pass reviewer since he should take a look at all new dependencies!

Aug 26 2022, 10:02 AM
abosh added inline comments to D4958: [lib, web, native] extract getting the keyserver admin.
Aug 26 2022, 9:56 AM
abosh requested changes to D4958: [lib, web, native] extract getting the keyserver admin.

One inline question.

Aug 26 2022, 9:54 AM

Aug 25 2022

abosh accepted D4912: [web] Refactor `MessageTooltip` component.
Aug 25 2022, 11:26 AM
abosh accepted D4909: [web] Introduce `clearTooltip` and `renderTooltip` functions in `TooltipContext`.
Aug 25 2022, 11:16 AM
abosh closed D4899: [native] Convert `ColorSelectorModal` to a functional component.
Aug 25 2022, 11:06 AM
abosh committed rCOMMbbf01478c50d: [native] Convert `ColorSelectorModal` to a functional component (authored by abosh).
[native] Convert `ColorSelectorModal` to a functional component
Aug 25 2022, 11:06 AM
abosh requested review of D4955: [native] Make return value more concise in `uploadInProgress`.
Aug 25 2022, 11:03 AM
abosh updated the diff for D4899: [native] Convert `ColorSelectorModal` to a functional component.

Destructure changeThreadSettings so editColor doesn't recompute each time props changes. I think the reason I was confused before is because we also import changeThreadSettings from lib/actions/thread-actions (line 9) but it is also passed in as a prop with the same name.

Aug 25 2022, 11:03 AM
abosh attached a referenced file: F149480: image.png.
Aug 25 2022, 8:01 AM
abosh added inline comments to D4892: [native] Use `Array.some(...)` in `uploadInProgress`.
Aug 25 2022, 8:01 AM
abosh attached a referenced file: F149447: image.png.
Aug 25 2022, 8:01 AM
abosh updated the diff for D4899: [native] Convert `ColorSelectorModal` to a functional component.

Address @tomek's feedback. Added useCallback to memoize functions and destructured props.

Aug 25 2022, 7:51 AM