Looks good! Accepting, assuming the Test Plan has been re-run on the latest version of this diff.

I think I figured out what was breaking this. After inspecting the errors on the Docker keyserver builds, it seems that source-nvm.sh was still being executed by sh instead of bash, even though we had updated the keyserver Dockerfile in D4429. The issue was that there were other places in the codebase that were still sourcing source-nvm.sh in the current environment as opposed to running it in bash (as the shebang in source-nvm.sh indicates).

(btw seems like it'd be fairly easy to convert ColorSelectorModal to a functional component if you wanted to try doing that)

Some style fixes here and there! Should be good after that.

Done. See here: https://linear.app/comm/issue/ENG-1349/disable-save-button-after-settings-are-saved-in

address inline feedback (had a lowercase m)

@jonringer-comm Sure that’d be awesome! Here’s the Linear issue to track that: https://linear.app/comm/issue/ENG-1296/add-shellcheck-or-something-similar-to-the-ci

Retry Docker keyserver build

Yup, I understand. I only added the dependency to connect the two diffs since that diff must be landed for this one to work.

Simplify return value of changeThreadSettingsAction, per inline feedback

it's not clear which changes were already committed and which will be after clicking save button. The previous design was also affected, but after each save a user had to open the modal again and see the current server state. It might be even more confusing when there was an error.

This is running into some errors, and I think it has to do with the difference between sh and bash.

That does make sense. I think the only reason I'm suggesting it is because the old services CI used the run_server_image.sh script, so the new one here can also use its own script. But maybe since this is only one command (versus run_server_image.sh being two) it is not a big deal.

I guess you're right about that, since the scope of this diff is only to get the workflow added! The only thing I would consider is @palys-swm and @karol-bisztyga both were wondering if we could use run_server_image.sh for the command. You noted that the run_server_image.sh script has an extra command and I noted that it doesn't run with the --no-cache flag. But their concern is still valid since the command is repeated many times over a lot of the service workflows. I guess for the future, for all the workflow diffs you put up with that command we should write a script, right? But I wasn't sure if that was something we all agreed on, so I wanted your input, hence the request changes so you'd see the inline comment in your queue.

Cool! Thanks for doing that.

Updated styling to make the button look good on Nexus 5 (which is a huge/wide screen). The EditPassword styling did not work with this large of a phone screen.

Never mind, resolved the bug. It was something in ColorPickerModal that was causing the issue. The Save button works as expected on iOS and Android.

Running into some bugs with the onPress function on Android that may have been introduced as a result of this change (this bug existed before but it returned now). Will update as I investigate.

Can you please split this diff into two: one that does the move, and another that does the changes?

even if you're not sure it requires changes! Otherwise, the diff won't be on @atul's queue

Ok! I'll do that from now on.

Ah, thanks! Just using a variable and throwing an exception every second time. Sometimes the simplest solution is the best.

Can you test bash/dc.sh up --build and make sure it works?

Makes sense. But does this depend on the other open diffs you have for each service's workflow? If so, we should wait on landing this. If not, looks good.