Page MenuHomePhabricator
Feed Advanced Search

Sep 8 2022

karol closed D5020: [services] Backup - Use Blob client in c++ - Implement pull backup.
Sep 8 2022, 4:10 AM
karol closed D5024: [services] Rust Integration - Catch std::exception in base bidi reactor.
Sep 8 2022, 4:10 AM
karol committed rCOMM965866378b2f: [services] Backup - Use Blob client in c++ - Implement pull backup (authored by karol).
[services] Backup - Use Blob client in c++ - Implement pull backup
Sep 8 2022, 4:10 AM
karol closed D5019: [services] Backup - Use Blob client in c++ - Implement send log.
Sep 8 2022, 4:10 AM
karol closed D5018: [services] Backup - Use Blob client in c++ - Implement add attachment.
Sep 8 2022, 4:10 AM
karol committed rCOMM62487114bb04: [services] Rust Integration - Catch std::exception in base bidi reactor (authored by karol).
[services] Rust Integration - Catch std::exception in base bidi reactor
Sep 8 2022, 4:10 AM
karol committed rCOMMd92ff5a3dcfd: [services] Backup - Use Blob client in c++ - Implement send log (authored by karol).
[services] Backup - Use Blob client in c++ - Implement send log
Sep 8 2022, 4:10 AM
karol committed rCOMM0b822963c7ec: [services] Backup - Use Blob client in c++ - Implement add attachment (authored by karol).
[services] Backup - Use Blob client in c++ - Implement add attachment
Sep 8 2022, 4:10 AM
karol closed D5017: [services] Backup - Use Blob client in c++ - Implement create new backup.
Sep 8 2022, 4:10 AM
karol closed D5016: [services] Backup - Blob Get Client - Add terminate.
Sep 8 2022, 4:10 AM
karol closed D5015: [services] Backup - Blob Get Client - Add blocking read.
Sep 8 2022, 4:10 AM
karol closed D5014: [services] Backup - Blob Get Client - Add initialize.
Sep 8 2022, 4:10 AM
karol committed rCOMM5abe8a40044a: [services] Backup - Use Blob client in c++ - Implement create new backup (authored by karol).
[services] Backup - Use Blob client in c++ - Implement create new backup
Sep 8 2022, 4:10 AM
karol committed rCOMM440114cd315c: [services] Backup - Blob Get Client - Add terminate (authored by karol).
[services] Backup - Blob Get Client - Add terminate
Sep 8 2022, 4:10 AM
karol committed rCOMM0edcf73c41af: [services] Backup - Blob Get Client - Add blocking read (authored by karol).
[services] Backup - Blob Get Client - Add blocking read
Sep 8 2022, 4:10 AM
karol committed rCOMM8949d823fda9: [services] Backup - Blob Get Client - Add initialize (authored by karol).
[services] Backup - Blob Get Client - Add initialize
Sep 8 2022, 4:10 AM
karol closed D5012: [services] Backup - Blob Put Client - Add terminate.
Sep 8 2022, 4:10 AM
karol closed D5011: [services] Backup - Blob Put Client - Add write.
Sep 8 2022, 4:10 AM
karol closed D5013: [services] Backup - Blob Get Client - Add base structure.
Sep 8 2022, 4:10 AM
karol committed rCOMM77d843164f0b: [services] Backup - Blob Get Client - Add base structure (authored by karol).
[services] Backup - Blob Get Client - Add base structure
Sep 8 2022, 4:10 AM
karol committed rCOMM6cbd2d4384fa: [services] Backup - Blob Put Client - Add terminate (authored by karol).
[services] Backup - Blob Put Client - Add terminate
Sep 8 2022, 4:10 AM
karol committed rCOMM6689f947442f: [services] Backup - Blob Put Client - Add write (authored by karol).
[services] Backup - Blob Put Client - Add write
Sep 8 2022, 4:10 AM
karol closed D5010: [services] Backup - Blob Put Client - Add blocking read.
Sep 8 2022, 4:10 AM
karol closed D5009: [services] Backup - Blob Put Client - Add initialize.
Sep 8 2022, 4:10 AM
karol committed rCOMMc915b14cca4a: [services] Backup - Blob Put Client - Add blocking read (authored by karol).
[services] Backup - Blob Put Client - Add blocking read
Sep 8 2022, 4:10 AM
karol closed D5008: [services] Backup - Blob Put Client - Add address constant.
Sep 8 2022, 4:10 AM
karol committed rCOMM4b6b03909f82: [services] Backup - Blob Put Client - Add initialize (authored by karol).
[services] Backup - Blob Put Client - Add initialize
Sep 8 2022, 4:10 AM
karol committed rCOMMa9fbedbf1692: [services] Backup - Blob Put Client - Add address constant (authored by karol).
[services] Backup - Blob Put Client - Add address constant
Sep 8 2022, 4:10 AM
karol closed D5006: [services] Backup - Blob Put Client - Add helper functions.
Sep 8 2022, 4:10 AM
karol closed D5007: [services] Backup - Blob Put Client - Install async stream.
Sep 8 2022, 4:10 AM
karol committed rCOMM4a1b95c4374f: [services] Backup - Blob Put Client - Install async stream (authored by karol).
[services] Backup - Blob Put Client - Install async stream
Sep 8 2022, 4:10 AM
karol committed rCOMMa20c5f282130: [services] Backup - Blob Put Client - Add helper functions (authored by karol).
[services] Backup - Blob Put Client - Add helper functions
Sep 8 2022, 4:10 AM
karol closed D5005: [services] Backup - Blob Put Client - Add essential objects.
Sep 8 2022, 4:10 AM
karol closed D5004: [services] Backup - Blob Put Client - Update put API.
Sep 8 2022, 4:10 AM
karol committed rCOMMfe23b0156554: [services] Backup - Blob Put Client - Add essential objects (authored by karol).
[services] Backup - Blob Put Client - Add essential objects
Sep 8 2022, 4:10 AM
karol committed rCOMM0e63f2b49414: [services] Backup - Blob Put Client - Update put API (authored by karol).
[services] Backup - Blob Put Client - Update put API
Sep 8 2022, 4:10 AM
karol closed D5002: [services] Backup - Tests - Pull Backup - Improve logging.
Sep 8 2022, 4:10 AM
karol closed D5003: [services] Backup - Add tools for blob client.
Sep 8 2022, 4:10 AM
karol committed rCOMM5e99a40b0379: [services] Backup - Add tools for blob client (authored by karol).
[services] Backup - Add tools for blob client
Sep 8 2022, 4:09 AM
karol committed rCOMMd7a9a55923a4: [services] Backup - Tests - Pull Backup - Improve logging (authored by karol).
[services] Backup - Tests - Pull Backup - Improve logging
Sep 8 2022, 4:09 AM
karol updated the diff for D5034: [services] Rust Integration - Backup - Rust - Add converting functions.

rebase

Sep 8 2022, 4:04 AM
karol updated the diff for D5031: [services] Rust Integration - Backup - Make check_error shared.

rebase

Sep 8 2022, 4:04 AM
karol updated the diff for D5030: [services] Rust Integration - Backup - Make report_error shared.

rebase

Sep 8 2022, 4:03 AM
karol updated the diff for D5029: [services] Rust Integration - Backup - Stop rethrowing in create new backup reactor.

rebase

Sep 8 2022, 4:03 AM
karol updated the diff for D5027: [services] Rust Integration - Backup - Stop rethrowing in send log reactor.

rebase

Sep 8 2022, 4:03 AM
karol updated the diff for D5026: [services] Rust Integration - Catch std::exception in base write reactor.

rebase

Sep 8 2022, 4:02 AM
karol updated the diff for D5025: [services] Rust Integration - Catch std::exception in base read reactor.

rebase

Sep 8 2022, 4:02 AM
karol updated the diff for D5024: [services] Rust Integration - Catch std::exception in base bidi reactor.

rebase

Sep 8 2022, 4:02 AM
karol updated the diff for D5020: [services] Backup - Use Blob client in c++ - Implement pull backup.

rebase

Sep 8 2022, 4:01 AM
karol updated the diff for D5019: [services] Backup - Use Blob client in c++ - Implement send log.

rebase

Sep 8 2022, 4:01 AM
karol updated the diff for D5018: [services] Backup - Use Blob client in c++ - Implement add attachment.

rebase

Sep 8 2022, 4:01 AM
karol updated the diff for D5017: [services] Backup - Use Blob client in c++ - Implement create new backup.

rebase

Sep 8 2022, 4:01 AM
karol updated the diff for D5016: [services] Backup - Blob Get Client - Add terminate.

rebase

Sep 8 2022, 4:01 AM
karol updated the diff for D5015: [services] Backup - Blob Get Client - Add blocking read.

rebase

Sep 8 2022, 4:00 AM
karol updated the diff for D5014: [services] Backup - Blob Get Client - Add initialize.

rebase

Sep 8 2022, 4:00 AM
karol updated the diff for D5013: [services] Backup - Blob Get Client - Add base structure.

rebase

Sep 8 2022, 4:00 AM
karol updated the diff for D5012: [services] Backup - Blob Put Client - Add terminate.

rebase

Sep 8 2022, 4:00 AM
karol updated the diff for D5011: [services] Backup - Blob Put Client - Add write.

rebase

Sep 8 2022, 3:59 AM
karol updated the diff for D5010: [services] Backup - Blob Put Client - Add blocking read.

rebase

Sep 8 2022, 3:59 AM
karol updated the diff for D5009: [services] Backup - Blob Put Client - Add initialize.

rebase

Sep 8 2022, 3:59 AM
karol updated the diff for D5008: [services] Backup - Blob Put Client - Add address constant.

rebase

Sep 8 2022, 3:58 AM
karol updated the diff for D5007: [services] Backup - Blob Put Client - Install async stream.

rebase

Sep 8 2022, 3:58 AM
karol updated the diff for D5006: [services] Backup - Blob Put Client - Add helper functions.

rebase

Sep 8 2022, 3:57 AM
karol updated the diff for D5005: [services] Backup - Blob Put Client - Add essential objects.

rebase

Sep 8 2022, 3:57 AM
karol updated the diff for D5004: [services] Backup - Blob Put Client - Update put API.

rebase

Sep 8 2022, 3:56 AM
karol updated the diff for D5003: [services] Backup - Add tools for blob client.

rebase

Sep 8 2022, 3:56 AM
karol updated the diff for D5002: [services] Backup - Tests - Pull Backup - Improve logging.

rebase

Sep 8 2022, 3:56 AM
karol added inline comments to D5018: [services] Backup - Use Blob client in c++ - Implement add attachment.
Sep 8 2022, 3:48 AM
karol added inline comments to D5014: [services] Backup - Blob Get Client - Add initialize.
Sep 8 2022, 3:41 AM
karol added a comment to D5011: [services] Backup - Blob Put Client - Add write.

We should probably have done more "foundation" work on logging and other canonical practices before creating such a large stack of "needing to be addressed concerns"

Sep 8 2022, 3:39 AM
karol added inline comments to D5034: [services] Rust Integration - Backup - Rust - Add converting functions.
Sep 8 2022, 3:37 AM
karol added inline comments to D5020: [services] Backup - Use Blob client in c++ - Implement pull backup.
Sep 8 2022, 3:32 AM
karol added inline comments to D5017: [services] Backup - Use Blob client in c++ - Implement create new backup.
Sep 8 2022, 3:30 AM
karol updated the diff for D5010: [services] Backup - Blob Put Client - Add blocking read.

address comment

Sep 8 2022, 3:26 AM
karol added inline comments to D5009: [services] Backup - Blob Put Client - Add initialize.
Sep 8 2022, 3:13 AM
karol added inline comments to D5009: [services] Backup - Blob Put Client - Add initialize.
Sep 8 2022, 3:10 AM
karol added inline comments to D5004: [services] Backup - Blob Put Client - Update put API.
Sep 8 2022, 1:14 AM
karol added a comment to D5002: [services] Backup - Tests - Pull Backup - Improve logging.

Agreed, but why create work for others?

Sep 8 2022, 1:12 AM

Sep 7 2022

karol requested review of D5017: [services] Backup - Use Blob client in c++ - Implement create new backup.
Sep 7 2022, 3:54 AM
karol updated the diff for D5018: [services] Backup - Use Blob client in c++ - Implement add attachment.

remove comments

Sep 7 2022, 2:34 AM
karol planned changes to D5018: [services] Backup - Use Blob client in c++ - Implement add attachment.

remove the comments

Sep 7 2022, 2:32 AM
karol updated the diff for D5071: [services] Rust Integration - c++ - Implement worker in write reactor.

rebase

Sep 7 2022, 2:18 AM
karol updated the diff for D5070: [services] Rust Integration - c++ - Implement worker in read reactor.

remove comments

Sep 7 2022, 2:17 AM
karol updated the diff for D5069: [services] Rust Integration - c++ - Implement worker in bidi reactor.

remove comments

Sep 7 2022, 2:16 AM
karol planned changes to D5071: [services] Rust Integration - c++ - Implement worker in write reactor.
Sep 7 2022, 2:00 AM
karol planned changes to D5070: [services] Rust Integration - c++ - Implement worker in read reactor.
Sep 7 2022, 2:00 AM
karol planned changes to D5069: [services] Rust Integration - c++ - Implement worker in bidi reactor.
Sep 7 2022, 2:00 AM
karol requested review of D5012: [services] Backup - Blob Put Client - Add terminate.
Sep 7 2022, 1:12 AM
karol added a comment to D5002: [services] Backup - Tests - Pull Backup - Improve logging.

@jon what is the ETA of the review here? This is the very first diff in the stack so it should be prioritized, right? Thanks!

Sep 7 2022, 12:59 AM
karol requested review of D5005: [services] Backup - Blob Put Client - Add essential objects.

If the client gets to be in an unhealthy state, then there should be some logic to get try and get the client back into a healthy state and retry the get/put. Currently, an unhealthy client will both report an error and drop the message.

Sep 7 2022, 12:58 AM

Sep 6 2022

karol updated the summary of D5074: [services] Rust Integration - Backup - c++ - Fix wrong order of attachment holders in tests.
Sep 6 2022, 7:40 AM
karol updated the summary of D5073: [services] Rust Integration - Backup - c++ - Use uuid instead of current timestamp when generating log id.
Sep 6 2022, 7:37 AM
karol requested review of D5074: [services] Rust Integration - Backup - c++ - Fix wrong order of attachment holders in tests.
Sep 6 2022, 7:35 AM
karol updated the summary of D5072: [services] Rust Integration - Backup - Rust - Fix wrong order of logs in the tests.
Sep 6 2022, 7:35 AM
karol requested review of D5073: [services] Rust Integration - Backup - c++ - Use uuid instead of current timestamp when generating log id.
Sep 6 2022, 7:35 AM
karol requested review of D5072: [services] Rust Integration - Backup - Rust - Fix wrong order of logs in the tests.
Sep 6 2022, 7:33 AM
karol requested review of D5071: [services] Rust Integration - c++ - Implement worker in write reactor.
Sep 6 2022, 7:32 AM
karol requested review of D5069: [services] Rust Integration - c++ - Implement worker in bidi reactor.
Sep 6 2022, 7:31 AM
karol requested review of D5068: [services] Rust Integration - c++ - Add worker.
Sep 6 2022, 7:31 AM
karol requested review of D5070: [services] Rust Integration - c++ - Implement worker in read reactor.
Sep 6 2022, 7:29 AM