Page MenuHomePhorge
Feed Search

Search
Use Results
Hide Query

Sep 27 2022

michal updated the diff for D5219: [native] Unify thread settings accessibility.

Update

Sep 27 2022, 10:01 AM
michal updated the diff for D5229: [native] Warn if notif is too big after omiting messageInfo.

Update

Sep 27 2022, 9:09 AM
michal updated the diff for D5229: [native] Warn if notif is too big after omiting messageInfo.

Update

Sep 27 2022, 8:57 AM
michal updated the summary of D5219: [native] Unify thread settings accessibility.
Sep 27 2022, 8:48 AM
michal updated the summary of D5219: [native] Unify thread settings accessibility.
Sep 27 2022, 8:47 AM

Sep 26 2022

michal requested review of D5229: [native] Warn if notif is too big after omiting messageInfo.
Sep 26 2022, 5:01 PM
michal updated the test plan for D5218: [native] Fix wrong title during thread creation.
Sep 26 2022, 2:31 PM
michal updated the diff for D5218: [native] Fix wrong title during thread creation.

Run CI, tested logged in as Ashoat

Sep 26 2022, 2:29 PM
michal added a comment to D5218: [native] Fix wrong title during thread creation.

Additional info to the previous comment: it doesn't happen on web because when there are no users selected, the search fills the whole screen and no title is displayed.

Sep 26 2022, 1:16 PM
michal updated the diff for D5218: [native] Fix wrong title during thread creation.

Updated the diff to use extracted method (I'm not sure if threadMembersWithoutAddedAshoat is a good name but I couldn't think of a better one...), thanks for the help!
Also, would it be better to do this in a separate diff? I'm still not sure when should I split things into other diffs.

Sep 26 2022, 9:59 AM
michal planned changes to D5219: [native] Unify thread settings accessibility.
Sep 26 2022, 8:42 AM

Sep 23 2022

michal requested review of D5219: [native] Unify thread settings accessibility.
Sep 23 2022, 2:37 PM
michal requested review of D5218: [native] Fix wrong title during thread creation.
Sep 23 2022, 1:00 PM

Sep 22 2022

michal requested review of D5213: [native] Type global.CommCoreModule.
Sep 22 2022, 1:37 PM

Sep 21 2022

michal requested review of D5203: [services] Move constants to a separate file in commtest.
Sep 21 2022, 11:59 AM
michal requested review of D5202: [native] Move tabNavigator listener to useEffect.
Sep 21 2022, 11:18 AM
michal requested review of D5201: [native] Throw JSError in sync functions.
Sep 21 2022, 10:20 AM
michal added 1 blocking reviewer(s) for D5189: [services] Move common files from tests to src: tomek.
Sep 21 2022, 8:55 AM
michal added a comment to D5189: [services] Move common files from tests to src.

Good point, I will try to keep that in mind

Sep 21 2022, 8:09 AM

Sep 20 2022

michal requested review of D5192: [native] disable forceDarkAllowed on android.
Sep 20 2022, 1:00 PM
michal updated the summary of D5189: [services] Move common files from tests to src.
Sep 20 2022, 10:09 AM
michal requested review of D5189: [services] Move common files from tests to src.
Sep 20 2022, 10:07 AM
michal updated the diff for D5171: [services] Remove path imports in tests.

Update

Sep 20 2022, 9:23 AM

Sep 19 2022

michal added a comment to D5143: [native] move threadInfo caching logic.

Should I create a separate task for moving tabNavigation listener to useEffect or just continue on this?

Sep 19 2022, 3:53 PM
michal updated the diff for D5143: [native] move threadInfo caching logic.

Update

Sep 19 2022, 3:47 PM
michal updated the diff for D5142: [native] fix missing threadInfo in thread settings.

Update

Sep 19 2022, 3:42 PM
michal requested review of D5171: [services] Remove path imports in tests.
Sep 19 2022, 11:15 AM
michal updated the diff for D5143: [native] move threadInfo caching logic.

Update

Sep 19 2022, 9:18 AM
michal updated the diff for D5142: [native] fix missing threadInfo in thread settings.

Update

Sep 19 2022, 9:00 AM
michal added 1 blocking reviewer(s) for D5159: [lib] Show parent thread members before community members: tomek.
Sep 19 2022, 8:35 AM
commpeopleops renamed michal.
Sep 19 2022, 12:27 AM

Sep 16 2022

michal requested review of D5159: [lib] Show parent thread members before community members.
Sep 16 2022, 9:31 AM

Sep 15 2022

michal updated the summary of D5143: [native] move threadInfo caching logic.
Sep 15 2022, 9:49 AM
michal requested review of D5143: [native] move threadInfo caching logic.
Sep 15 2022, 9:41 AM
michal requested review of D5142: [native] fix missing threadInfo in thread settings.
Sep 15 2022, 9:38 AM
First
Prev