Changed context properties to read-only.

Fixed conditional, so it saves cursor position in pending threads.

I'd say, if we save drafts, we should also save cursorPosition. It may be frustrating for user to edit two drafts at the same time, and have they cursor revert to the start of textarea every time. I'm not really sure how to estimate cost of keeping it, but if it isn't too high I'd keep it as nice to have feature.

Responded to inlines.

Fixed what inline pointed out.
Performed requested test.

Responed to last nit.

Responded to inlines.

Rebased

Rebased

Final fix. I added wrong files by ammending mistake.

I messed up with what diff should I ammend. Fixed now. Also responded to nit comments above

Responded to inlines.

Responded to inlines.

Fixed Item props.

Responded to inline comments.

Responded to inline comments. After discussion with @tomek I added BaseInputProps = PasswordProps and created InputProps as its extension.

Responded to inline comments. Tries to properly use useCallback resulted in creating extra small component Item added in sidebar-item.react.js.
Spotted a visual bug Swipeable row's height was smaller then height of wrapping component (you can observed it in video above when I swipe threads - green and red buttons do not fill entire height). It should be fixed now.

Right, put SwipeableThread inside of Button now, so it is handled properly

Thanks for extensive review @kamil. I responded to inline comments.
Also deleted native files from this diff and will put them in another one.

Updated cocoapods

You're right. Fixed

Another one, realised, I should have used >= instead of >

Abolutely right, sorry for that. I missed the logic inversion in that case.

Return early. Removed unneccessary invariant.

Added description text and rebased.

Fixed smaller issues Tomek mentioned.
The one about Ashoat's suggestion is lef for discussion.
Now I realized it would be better to refactor it, so we use invalid_credentials now, as
it would make sense it context of whole application and how invalid_credentials and invalid_parameters are used.
Waiting for your suggestions.

rebased

Ok

Ok

fixed, thanks @tomek

Looks good, thanks for linking discussion on Linear, it made the changes clear

Looks good to me :)

They are still used. onUnsuccessfulLoginAlertAckowledged is new function used when either username or password. onUsernameAlertAcknowledged is still used when verifying correctness of username. I'm planning on changing them as we don't want to clear form fields as mentioned here: https://linear.app/comm/issue/ENG-2050/[web][native]-add-see-password-button-on-the-login-page-and-dont-clear

Update ticks and uppercases.

Updating D5368: [web][native][keyserver] Changing login screen so it displays identical error on wrong username and/or password.

Updating D5365: [web][native] Trimming whitespaces from username at login screen

Deleted console logs.

Updating D5315: [web] Closing modal with outside click changed

Hi, @ginsu, I used useRef instead useState, because we don't want to trigger component reload on every click, but we need to hold state with data about last event. If I understand it correctly useRef creates object that can hold any type of data, and one of use cases is to hold temporary states like that. That is also what @tomek suggested in one of previous comments. Let me know if should explicitly state that in comment or is explanation here sufficient?

Updating D5315: [web] Closing modal with outside click changed

Updating D5315: [web] Closing modal with outside click changed