Rebase on master
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed Search
Dec 21 2022
Dec 21 2022
Dec 20 2022
Dec 20 2022
I would really love for the Test Plan to actually test the Apache configuration to make sure it works. Is this handled somewhere else, or are we just hoping it works, and hoping that your reviewers will catch any errors?
Update template with settings from D5846
• jon added inline comments to D5900: [native] [6/40] RN 0.70: Update Android NDK to 24 for M1 hosts.
• jon accepted D5931: [services/commtest] Tunnelbroker - Adding the API integration tests call function.
was unable to do arc patch without a conflict, but overall looks good to me
• jon accepted D5929: [services/commtest] Tunnelbroker - Adding `deviceID` validation check function.
Would really like to see these tests get added to the CI. They are pretty expensive to run locally.
• jon accepted D5837: [services/commtest] Tunnelbroker - Adding of helper function for the `SessionSignature` client request.
LGTM
I think using the same names, but with and without .sh for the comm-dev file makes a mess
Address writeFile.writeFile feedback
Use Promise.all()
Heads-up, your screenshot failed to attach.
Dec 19 2022
Dec 19 2022
Await promises
Avoid whitespace removal
Address feedback
Minor fixes, address feedback
• jon requested changes to D5928: [services/commtest] Tunnelbroker - Adding the tonic client builder function.
Dec 16 2022
Dec 16 2022
Can you update your Test Plan to mention testing this on macOS?
Dec 15 2022
Dec 15 2022
Will landing this diff cause any issues for users who have MariaDB installed through Homebrew?
Also ran into expo-constants having a similar issue, which seems to have been fixed in the past few months, but we are still using older version.
See here – I don't think we need to ask the user to install Node 16. After the React Native / Expo updates, the path to Node should be saved when you run yarn, and the iOS build scripts should check that Node path and use it
We should very rarely have "N/A" as the Test Plan. Can you amend the Test Plan to mention testing that these configs of commapp_url.json and landing_url.json work?
• jon retitled D5847: [Nix] Provide default for squadcal_url.json from [Nix] Provide default for squalcal_url.json
Address feedback
Remove squadcal altogether for new developers
Dec 14 2022
Dec 14 2022
🤦♂️ right! Missed that we don't have any diffs in the stack that call this script.
🤦♂️ right! Missed that we don't have any diffs in the stack that call this script.
Address feedback
Apply typo fix to correct diff
Fix typo
Dec 13 2022
Dec 13 2022
Ensure pidfile directory exists before writing pidfile
Should be the same, was able to get the "clean" mac working after some refinement.
Rebase on master
rabbitmq has an unfree license, so you may need to build the package. But this command should run on m1 or intel