we can deprecate the original service (the one being renamed here)

how about identity.general? identity.client feels weird

Hmm are we using usernames as an identifier? Ideally we use user IDs for that

This honestly feels like bike-shedding… I’d love if we could start out the work on this project with a focus on derisking the big risks, rather than renaming things

LGTM

and we're doing some custom stuff instead of launchd

Fix compile errors

identity.proto should probably be renamed as identity_keyserver.proto. As I would like to add the client <-> identity protobuf file as identity_client.proto, which is confusing as we refer to the keyserver protos as "identity_client" in some parts of the code base. In other words, align the naming with the "comm" defintion of terms and move away with the more general gRPC definition of terms.

not sure why i reviewed knowing full well it was relating to the keyserver code, then responded about the server.

I think short term this is fine.

Move unneeded parameters to protobuf message creation

Consolidate imports

Apply error and typo feedback

Address varuns feedback

Explicitly await update user action

Restore rng parameter

Restore rng parameter

Rebase on master

Rebase on master

Rebase on master

Apply feedback, rebase on master

looks fine to me rust wise

otherwise looks fine rust wise

Make logging and errors more consistent

Handle promises more gracefully

Just got to the point of a successful update, still need to address feedback

Serialize messages in correct order

I'm still working on one remaining issue with message ordering, but wanted the diff to be up so varun had more time to review

We talked about the usage of access tokens, and decided that we can defer doing access_token validation when the client (not keyserver) is able to provide them.

We talked about the usage of access tokens, and decided that we can defer doing access_token validation when the client (not keyserver) is able to provide them.

I don't see anything I feel strongly about, I'll keep on the queue for others

Rebase on master

Rebase on master

Rebase on master

Rebase on top of latest master

We don't need 15 difference copies of the Arc wrapping; just when we cross a thread boundary like tokio::spawn.

Reuse registerUser request message

Include tag in commit name

Use user_id instead of username for identitifying users

Match registration shape exactly

mostly looks good.

the rust is pretty boilerplate, but I'll defer to someone else about intent

Looks okay to me, I'm assuming this is part of https://linear.app/comm/issue/ENG-2759

agree with bartek, something name <object>_is_<condition>, should probably return a boolean, or be renamed to more accurately describe what is going on.

Looks fine to me.

Seems like from ashoat's feedback the nonce is similar to a unique token, in which case I think this is alright.

Looks similar to other tables, so the syntax looks okay.