Moved FocusTrap to the ModalOverlay

Moved default background color

Memoized backgroundColor

In D7837#235331, @ashoat wrote:

In a previous comment, I said:

In D7837#233153, @ashoat wrote:

... then wrapping web/modals/modal.react.js in a <FocusTrap> component would make all of our modals "trap focus". This is probably a good thing to do for all modals, and I think it would solve the problem here.

@kuba, what do you think?

However, in this diff you've only added FocusTrap to your specific modal. Can you provide some detail as to why you took a different approach, and whether you considered the approach I suggested?

Fix - couldn't close edit modal

Fix updating height after text changes

Review

Updated styles

Fixed types

Added types for FocusTrap

Rebase

Added newline

Added FocusTrap for modals

Address review

I removed completely the width property from the EditTextMessage component. It turned out it was completely unnecessary.

Removed width property

Removed width from the EditTextMessage

Removed width parameter

Address review

Address review

Added invariant

Changed return type or preventCloseTab

Address review

Address review

Rebase

Rebase

Rebase

Rebase

Rebase

Rebase

Rebase

Rebase

Rebase

Rebase

Rebase

Merged with diff https://phab.comm.dev/D7828

Added setting error state, merged with next diff

Fixed one thing

Addressed review

In D7793#232996, @michal wrote:

Accepting, but please fix the icon before landing!

Address review

Merged with D7824

Addressed review

In D7789#232531, @ashoat wrote:

I was asking for links (hyperlinks) to the TypeScript types. In a previous comment I had requested:

Can you find the TypeScript types and try to base your new types on those, and make sure to include all relevant params?

Assuming you did that and found the TypeScript types, I'm now asking you to link those types. With the comments you left, it appears that some of them don't match, and I can't tell if they are TypeScript types or just other Flow types that we already have.

Clearing tooltip after entering edit mode

Added useMemo to modalOverlay

Rebase

Changed to the function component, addressed review

In D7793#232559, @michal wrote:

These //TODO comments make it hard to review this stack because now the diffs depend on both previous and future diffs. This diff in particular seem like it would be easy to merge with D7824. Is there a reason why you did it this way?

Adressed review

In D7789#232336, @ashoat wrote:

Can you link the TypeScript types you used as inspiration? It will make review a lot easier

Removed empty line

Change to function component

Rebase

Reverted moving to Partial due to errors

Added remaining properties to types

Added remaining properties

Fixed types, changed to AnimatedView instead of Animated.View