Handled issue in onChangeColor, per feedback.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
May 16 2022
May 12 2022
May 11 2022
Address inline feedback
May 9 2022
Removed case when queuedChanges.name and queuedChanges.description are '' (if the
user wants to clear the name/description, this is stil a change!).
May 6 2022
May 5 2022
rebase before landing
May 4 2022
Address feedback about outerRingStyle -- created new Stylesheet style for selected outerRing.
May 3 2022
Added translucent outer ring and removed checkmark to match web design.
May 2 2022
Addressed inline feedback and updated styles by removing glow. For now, it's basically mimicking the styles on web (see attached image) except the styles on web use a hover property which can't really be done on native. Instead, the checkmark is what indicates to the user what the current color is. Didn't seem to find a Figma design for native, so that might have to be updated or decided upon.
yeah, you're right. I saw it in the Linear issue and wanted to add it to bridge the contexts between the two issues, since we need to add a staging environment with a deploy preview to test this diff. Just edited the Test Plan to accurately describe what in this issue is related to Sandcastle.
Apr 29 2022
Are you guys talking about the horizontal lines in the red circles? Pretty sure those are just the strokes at the top/bottom of each thread settings "section" in the view behind the modal?
Apr 27 2022
Address feedback about Apple Silicon/Intel Mac wording. Looked through the docs and saw that the S in Apple silicon was lowercase (as it should be) and Intel is referred to as Intel x86-64. The term "Apple silicon Macs" is only referred to in the Python 2 section, but not paired with "Intel x86-64 Macs," so this has been revised. Also replaced all single quote characters with apostrophes.
Removed extraneous colon (was in Markdown editor, just forgot to include it in VS Code in last commit)
Address feedback about inaccurate claim with what Homebrew prints and order of narrative. Also replaced . with \. as per inline comment.
Apr 25 2022
Apr 24 2022
fix git issues
Apr 21 2022
Apr 20 2022
Updated memoization to memoize array passed into style prop for the View in ColorSelectorButton.
Memoized the backgroundColor style attribute for ColorSelectorButton.
Modify this diff to only include ColorSelectorButton.
Apr 19 2022
Apr 13 2022
Apr 12 2022
Updated "See more..." button alignment to match @benschac's changes
Apr 11 2022
Apr 8 2022
Removed div.main-header CSS from selector on <a> tag. Also added aria-label: Go to Comm Home to wordmark. Screenreader now reads "Go to Comm Home" when clicking on wordmark.
Apr 7 2022
Updated h1 tag by wrapping Comm text in an anchor, per @benschac's suggestion. Also allows for a title attribute on the a when hovering, which increases accessibility.
Apr 6 2022
Moved CSS into already existing div.main-header > h1 selector. Will defer to your guys' input on adding the .wordmark class because there was already a CSS selector/CSS styles that were in the h1 selector, although I think it's clearer if we rename the selector to use a class instead of h1.
Clicking on the wordmark takes the user to the main Chat tab without refreshing the page. The <a> tag has been removed and instead the <h1> tag uses an onClick event handler to update the navigation info.
Yup, it should be yarn script dist/scripts/generate-olm-config.js because the JSON file does not exist, and it looks like that was the change that was made!
Apr 5 2022
Apr 4 2022
Removed function and used conditional rendering outside of JSX, per https://beta.reactjs.org/learn#conditional-rendering
Apr 3 2022
Removed ternary condition that returned JSX element and used function instead.
Apr 1 2022
Rebase before landing