rebase

Rebase before landing

Rebase

Rebase before landing

Rebase before landing

address review

Update diff

Send string on native and blob on web.

Sorry for the confusion. This differential was supposed to bo abandoned.

Sorry for the confusion. This differential was supposed to bo abandoned.

Update to simpler approach

I am actually starting to question this. While putting those diffs I came up with better idea how to achieve the same effect using just JS. I will try to get on phab tomorrow morning. The idea is to pass to createAPNsVisualNotif and createAndroidVisualNotif a map from stringified unencrypted notification + messageInfo to a promise resolving to its encrypted version and a hash.

Rebase before landing

Rebase before landing

Address review

rebase before landing

Rebase before landing

In D13334#376477, @ashoat wrote:

It appears that the only thing this diff is doing is having textMessageCreationSideEffectsFunc called after the text message is created for thick threads, but before the text message is created for thin threads.

Two questions:

1. Why do the side effects need to happen after the text message is created for thick threads?

Address review

Rebase master

Rebase before landing

Rebase before landing

Rebase before landing

Rebase before landing

rebase before landing

Made significant changes to address feedback regarding adding members to thick threads.

Address review

Make input type read only

rebase before landing

rebase before landing

Re-requesting review as this new check is much better - we won't try to create a session nor process any data with device that does not have sufficient code version.

More robust check. If the device doesn't support E2EE notifs we won't even try to create a notifs session with it.

Rebase before landing

Extract sidebar and dm_sidebar to constants

Set flag to true in pendingThreadID

In D13275#374497, @inka wrote:

Thank you! Would be great if you could attach a screenshot

Improve types

Implement union of types approach